Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196018: java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java fails #11213

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Nov 17, 2022

The issue contains evaluation:

  • the test is not failing on Windows
  • it also fails on Linux(but provided stack trace with failure is from different test)

I rechecked the test and it does not fail on all platforms.

Test is stabilized:

  • replaced synchronization on windowActivated event with standard robot.waitForIdle(); robot.delay(1000);
  • Robot autoDelay decreased to 250 to make the test go faster. It it still a reasonable value.

CI testing looks good also.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8196018: java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11213/head:pull/11213
$ git checkout pull/11213

Update a local copy of the PR:
$ git checkout pull/11213
$ git pull https://git.openjdk.org/jdk pull/11213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11213

View PR using the GUI difftool:
$ git pr show -t 11213

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11213.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2022

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 17, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196018: java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java fails

Reviewed-by: psadhukhan, serb, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

  • 59a308b: 8296632: Write a test to verify the content change of TextArea sends TextEvent
  • 11fc65f: 8023562: [TEST_BUG] java/awt/Mouse/EnterExitEvents/DragWindowTest.java failed on ubuntu 13 and mac 10.11
  • 2c692aa: 8297088: Update LCMS to 2.14
  • 9b4e0e8: 8297080: Remove com/sun/jdi/NashornPopFrameTest.java from the problem list
  • 3272954: 8297083: Remove vmTestbase/nsk/jvmti/GetAllThreads/allthr001 from problem list
  • c4b6920: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java
  • f34ca80: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
  • 13158cb: 8293041: --disable-@files option doesn't work and cause an error
  • 761a4f4: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
  • 2f2d404: 8297129: Inflater documentation refers to 'deflate' methods
  • ... and 51 more: https://git.openjdk.org/jdk/compare/eac26f4eb2b717676267c75e65e76fc3b958c9a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2022
Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on macOS and the test works normally with the test removed from the problem list.

@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

Going to push as commit 16ab754.
Since your change was applied there have been 88 commits pushed to the master branch:

  • 8b8d848: 8293422: DWARF emitted by Clang cannot be parsed
  • 59d8f67: 8297265: G1: Remove unnecessary null-check in RebuildCodeRootClosure::do_code_blob
  • 2fc340a: 8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar
  • e420661: 8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate
  • 891c706: 8295276: AArch64: Add backend support for half float conversion intrinsics
  • 3c09498: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • 45d1807: 6312651: Compiler should only use verified interface types for optimization
  • bcc6b12: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
  • fc61658: 8294591: Fix cast-function-type warning in TemplateTable
  • 544e317: 8059632: Method reference compilation uses incorrect qualifying type
  • ... and 78 more: https://git.openjdk.org/jdk/compare/eac26f4eb2b717676267c75e65e76fc3b958c9a7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022
@openjdk openjdk bot closed this Nov 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@azvegint Pushed as commit 16ab754.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants