-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297088: Update LCMS to 2.14 #11217
8297088: Update LCMS to 2.14 #11217
Conversation
Reviewed-by: honkar, prr
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
@alisenchung The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build change looks good.
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@@ -305,7 +305,7 @@ $(eval $(call SetupJdkLibrary, BUILD_LIBLCMS, \ | |||
common/awt/debug \ | |||
libawt/java2d, \ | |||
HEADERS_FROM_SRC := $(LIBLCMS_HEADERS_FROM_SRC), \ | |||
DISABLED_WARNINGS_gcc := format-nonliteral stringop-truncation, \ | |||
DISABLED_WARNINGS_gcc := format-nonliteral type-limits stringop-truncation, \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to report this upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File headers update, indentation & spacing looks good. |
/integrate |
Going to push as commit 2c692aa.
Your commit was automatically rebased without conflicts. |
@alisenchung Pushed as commit 2c692aa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Redo of 8295369: Update LCMS to 2.14
Update LCMS to newest release.
Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a build error in linux.
Automatic tests and J2D demo tests were run.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11217/head:pull/11217
$ git checkout pull/11217
Update a local copy of the PR:
$ git checkout pull/11217
$ git pull https://git.openjdk.org/jdk pull/11217/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11217
View PR using the GUI difftool:
$ git pr show -t 11217
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11217.diff