8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) #11218

bchristi-git · 2022-11-17T19:25:42Z

JDK-8290036 documented the shutdown sequence, noting that calling Runtime.halt() skips the shutdown sequence and immediately terminates the VM. Thus, "threads' current methods do not complete normally or abruptly; no finally clause of any method is executed".

One ramification of this is that resources within try-with-resource blocks will not be released. It would be good to state this explicitly.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Reviewers

Lance Andersen (@LanceAndersen - Reviewer) ⚠️ Review applies to 6df8acf8
Brian Burkhalter (@bplb - Reviewer) ⚠️ Review applies to cbba781f
Naoto Sato (@naotoj - Reviewer) ⚠️ Review applies to cbba781f
David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 4f2fb241
Stuart Marks (@stuart-marks - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11218/head:pull/11218
$ git checkout pull/11218

Update a local copy of the PR:
$ git checkout pull/11218
$ git pull https://git.openjdk.org/jdk pull/11218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11218

View PR using the GUI difftool:
$ git pr show -t 11218

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11218.diff

bridgekeeper · 2022-11-17T19:25:50Z

👋 Welcome back bchristi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-11-17T19:28:03Z

@bchristi-git The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-11-17T19:32:05Z

Webrevs

src/java.base/share/classes/java/lang/Runtime.java

bplb

Looks good now.

openjdk · 2022-11-17T20:35:56Z

@bchristi-git This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Reviewed-by: lancea, bpb, naoto, dholmes, smarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

c16eb89: 8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)"
3dfadee: 8292289: [vectorapi] Improve the implementation of VectorTestNode
d35e840: 8297295: Remove ThreadGroup.allowThreadSuspension
175e3d3: 8296149: Start of release updates for JDK 21
d562d3f: 8297642: PhaseIdealLoop::only_has_infinite_loops must detect all loops that never lead to termination
fc52f21: 8298255: JFR provide information about dynamization of number of compiler threads
e555d54: 8298383: JFR: GenerateJfrFiles.java lacks copyright header
c084431: 8298379: JFR: Some UNTIMED events only sets endTime
ea108f5: 8298129: Let checkpoint event sizes grow beyond u4 limit
165dcdd: 8297718: Make NMT free:ing protocol more granular
... and 23 more: https://git.openjdk.org/jdk/compare/39344840c7a5fbd37f6c6a972a89c3600396e878...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

bplb · 2022-11-17T20:36:01Z

Is a CSR needed here?

bchristi-git · 2022-11-17T22:06:47Z

Is a CSR needed here?

I will check, though the thought is that these are non-normative clarifications to the normative changes made by 8290036.

bchristi-git · 2022-11-18T21:18:25Z

(Updated the wording, per comment in the bug report)

bchristi-git · 2022-11-18T21:20:47Z

Is a CSR needed here?

I will check

A CSR is not needed.

naotoj

Looks good, Brent

src/java.base/share/classes/java/lang/Runtime.java

bchristi-git · 2022-12-06T22:01:42Z

What do people think of the latest changes?

dholmes-ora

One nit but otherwise seems fine to me.

Thanks.

src/java.base/share/classes/java/lang/Runtime.java

stuart-marks

Looks good!

bchristi-git · 2022-12-12T19:34:45Z

/integrate

openjdk · 2022-12-12T19:37:13Z

Going to push as commit c7aca73.
Since your change was applied there have been 65 commits pushed to the master branch:

781a2e0: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug
9ff85f6: 8298589: java/net/SctpSanity.java fail with NoClassDefFoundError: sun/nio/ch/sctp/UnsupportedUtil
81f57d5: 8298567: Make field in RandomAccessFile final
56c438b: 8297822: De-duplicate code in module jdk.sctp
fabda24: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
6c23b4f: 8298480: Remove unused KlassRemSet
8e5c331: 8298471: Parallel: Don't keep alive nmethods in Young GC
d646e32: 8298090: Use String.join() instead of manual loop in DescriptorSupport.toString
a37de62: 8298126: Print statistics for objects in CDS archive heap
8ea2a67: 8292265: Add old gen used field at G1HeapSummary JFR event
... and 55 more: https://git.openjdk.org/jdk/compare/39344840c7a5fbd37f6c6a972a89c3600396e878...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-12-12T19:37:31Z

@bchristi-git Pushed as commit c7aca73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

bchristi-git added 4 commits November 2, 2022 15:19

Update doc for Runtime class and halt() method

dffb37b

update doc changes

7f38c9c

update halt() @APinote

9e89769

Merge branch 'master' into 8295857

de091d8

openjdk bot added the rfr Pull request is ready for review label Nov 17, 2022

openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 17, 2022

bplb reviewed Nov 17, 2022

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

bplb reviewed Nov 17, 2022

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

LanceAndersen suggested changes Nov 17, 2022

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

It's "try-with-resources"

9983fa6

bplb approved these changes Nov 17, 2022

View reviewed changes

LanceAndersen approved these changes Nov 17, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2022

Mentioned effects are not a complete list

cbba781

naotoj approved these changes Nov 18, 2022

View reviewed changes

bplb approved these changes Nov 19, 2022

View reviewed changes

Update Runtime class doc re: other unexpected behaviors

6df8acf

LanceAndersen approved these changes Nov 22, 2022

View reviewed changes

dholmes-ora reviewed Nov 22, 2022

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

stuart-marks reviewed Nov 23, 2022

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

put examples into a list, in class doc only, not halt()

4f2fb24

dholmes-ora approved these changes Dec 7, 2022

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

bchristi-git added 2 commits December 7, 2022 09:28

'close' -> 'closed' in AutoCloseable link

db0ea77

Merge branch 'master' into 8295857

5d8b261

stuart-marks approved these changes Dec 8, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Dec 12, 2022

openjdk bot closed this Dec 12, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2022

8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) #11218

8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) #11218

bchristi-git commented Nov 17, 2022 •

edited by openjdk bot

bridgekeeper bot commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

mlbridge bot commented Nov 17, 2022 •

edited

bplb left a comment

openjdk bot commented Nov 17, 2022 •

edited

bplb commented Nov 17, 2022

bchristi-git commented Nov 17, 2022

bchristi-git commented Nov 18, 2022

bchristi-git commented Nov 18, 2022

naotoj left a comment

bchristi-git commented Dec 6, 2022

dholmes-ora left a comment

stuart-marks left a comment

bchristi-git commented Dec 12, 2022

openjdk bot commented Dec 12, 2022

openjdk bot commented Dec 12, 2022

8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) #11218

8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) #11218

Conversation

bchristi-git commented Nov 17, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

mlbridge bot commented Nov 17, 2022 • edited

Webrevs

bplb left a comment

Choose a reason for hiding this comment

openjdk bot commented Nov 17, 2022 • edited

bplb commented Nov 17, 2022

bchristi-git commented Nov 17, 2022

bchristi-git commented Nov 18, 2022

bchristi-git commented Nov 18, 2022

naotoj left a comment

Choose a reason for hiding this comment

bchristi-git commented Dec 6, 2022

dholmes-ora left a comment

Choose a reason for hiding this comment

stuart-marks left a comment

Choose a reason for hiding this comment

bchristi-git commented Dec 12, 2022

openjdk bot commented Dec 12, 2022

openjdk bot commented Dec 12, 2022

bchristi-git commented Nov 17, 2022 •

edited by openjdk bot

mlbridge bot commented Nov 17, 2022 •

edited

openjdk bot commented Nov 17, 2022 •

edited