Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297217: Incorrect generation name in the heap verification log message with Serial GC #11219

Closed
wants to merge 1 commit into from

Conversation

ashu-mehra
Copy link
Contributor

@ashu-mehra ashu-mehra commented Nov 17, 2022

Please review this trivial patch to fix the young generation name displayed in the log message during heap verification for Serial GC.

Signed-off-by: Ashutosh Mehra asmehra@redhat.com


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297217: Incorrect generation name in the heap verification log message with Serial GC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11219/head:pull/11219
$ git checkout pull/11219

Update a local copy of the PR:
$ git checkout pull/11219
$ git pull https://git.openjdk.org/jdk pull/11219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11219

View PR using the GUI difftool:
$ git pr show -t 11219

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11219.diff

Signed-off-by: Ashutosh Mehra <asmehra@redhat.com>
@ashu-mehra ashu-mehra changed the title Fix the log message to display young gen name 8297217: Incorrect generation name in the heap verification log message with Serial GC Nov 17, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2022

👋 Welcome back ashu-mehra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@ashu-mehra The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 17, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2022

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@ashu-mehra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297217: Incorrect generation name in the heap verification log message with Serial GC

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 761a4f4: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
  • 2f2d404: 8297129: Inflater documentation refers to 'deflate' methods
  • dd18d76: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
  • 2b6dbc7: 8293856: AArch64: Remove clear_inst_mark from aarch64_enc_java_dynamic_call
  • 2f063b8: 8296846: Minor cleanup of some dead code in Flow.java
  • ab6b7ef: 8296901: Do not create unsigned certificate and CRL
  • 7b3984c: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads
  • 373e52c: 8296785: Use realloc for CHeap-allocated BitMaps
  • a53be20: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
  • 66228f7: 8297074: Use enhanced-for cycle instead of Enumeration in javax.crypto

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kimbarrett, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2022
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@ashu-mehra
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@ashu-mehra
Your change (at version 843a5d6) is now ready to be sponsored by a Committer.

@kimbarrett
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 20, 2022

Going to push as commit 651e547.
Since your change was applied there have been 34 commits pushed to the master branch:

  • dd55310: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
  • 3ea8971: 8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp
  • 0a3b0fc: 8296784: Provide clean mallinfo/mallinfo2 wrapper for Linux glibc platforms
  • 7b3d581: 8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList
  • 251e065: 8296764: NMT: reduce loads in os::malloc
  • 0845b39: 8296796: Provide clean, platform-agnostic interface to C-heap trimming
  • c50a904: 8297195: AWTAccessor and SwingAccessor should avoid double racy reads from non-volatile fields
  • 906f1ca: 8292317: Missing null check for Iterator.forEachRemaining implementations
  • 0ec575a: 8297289: problem list runtime/vthread/RedefineClass.java and TestObjectAllocationSampleEvent.java
  • dcb8375: 8245246: Deprecate -profile option in javac
  • ... and 24 more: https://git.openjdk.org/jdk/compare/819af69f408261f55af883ba015c1f6179236582...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2022
@openjdk openjdk bot closed this Nov 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 20, 2022
@openjdk
Copy link

openjdk bot commented Nov 20, 2022

@kimbarrett @ashu-mehra Pushed as commit 651e547.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ashu-mehra ashu-mehra deleted the JDK-8297217 branch February 7, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants