Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Nov 18, 2022

Test serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp. It starts 2000 threads at the same time. However, there is no goal to start them simultaneously. It is needed just to start a lot of threads. So fix is to start them by smaller groups.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11228/head:pull/11228
$ git checkout pull/11228

Update a local copy of the PR:
$ git checkout pull/11228
$ git pull https://git.openjdk.org/jdk pull/11228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11228

View PR using the GUI difftool:
$ git pr show -t 11228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11228.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp

Reviewed-by: cjplummer, kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 9b4e0e8: 8297080: Remove com/sun/jdi/NashornPopFrameTest.java from the problem list
  • 3272954: 8297083: Remove vmTestbase/nsk/jvmti/GetAllThreads/allthr001 from problem list
  • c4b6920: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java
  • f34ca80: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
  • 13158cb: 8293041: --disable-@files option doesn't work and cause an error
  • 761a4f4: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
  • 2f2d404: 8297129: Inflater documentation refers to 'deflate' methods
  • dd18d76: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
  • 2b6dbc7: 8293856: AArch64: Remove clear_inst_mark from aarch64_enc_java_dynamic_call
  • 2f063b8: 8296846: Minor cleanup of some dead code in Flow.java
  • ... and 1 more: https://git.openjdk.org/jdk/compare/7b3984cb5a08edb99a233c28331c00b25457d664...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2022
@lmesnik
Copy link
Member Author

lmesnik commented Nov 19, 2022

/itegrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2022

@lmesnik Unknown command itegrate - for a list of valid commands use /help.

@lmesnik
Copy link
Member Author

lmesnik commented Nov 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2022

Going to push as commit 3ea8971.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 0a3b0fc: 8296784: Provide clean mallinfo/mallinfo2 wrapper for Linux glibc platforms
  • 7b3d581: 8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList
  • 251e065: 8296764: NMT: reduce loads in os::malloc
  • 0845b39: 8296796: Provide clean, platform-agnostic interface to C-heap trimming
  • c50a904: 8297195: AWTAccessor and SwingAccessor should avoid double racy reads from non-volatile fields
  • 906f1ca: 8292317: Missing null check for Iterator.forEachRemaining implementations
  • 0ec575a: 8297289: problem list runtime/vthread/RedefineClass.java and TestObjectAllocationSampleEvent.java
  • dcb8375: 8245246: Deprecate -profile option in javac
  • 52494df: 8290845: Consider an alternative item separator for multi-item option values
  • c56c69e: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
  • ... and 18 more: https://git.openjdk.org/jdk/compare/7b3984cb5a08edb99a233c28331c00b25457d664...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 19, 2022
@openjdk openjdk bot closed this Nov 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2022
@openjdk
Copy link

openjdk bot commented Nov 19, 2022

@lmesnik Pushed as commit 3ea8971.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8269817 branch June 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

4 participants