JDK-8296743: Tighten Class.getModifiers spec for array classes #11229

jddarcy · 2022-11-18T03:26:38Z

Update the spec of Class.getModifiers to match long-standing behavior for primitive and array classes. Remove unneeded implementation flexibility with regard to setting other bit positions. This work was prompted to better support anticipated future Valhalla changes.

Please also review the CSR: https://bugs.openjdk.org/browse/JDK-8297237

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires a CSR request to be approved

Issues

JDK-8296743: Tighten Class.getModifiers spec for array classes
JDK-8297237: Tighten Class.getModifiers spec for array classes (CSR)

Reviewers

Roger Riggs (@RogerRiggs - Reviewer) ⚠️ Review applies to 3321b086
Mandy Chung (@mlchung - Reviewer) ⚠️ Review applies to 375c260d
Dan Heidinga (@DanHeidinga - no project role) ⚠️ Review applies to 375c260d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11229/head:pull/11229
$ git checkout pull/11229

Update a local copy of the PR:
$ git checkout pull/11229
$ git pull https://git.openjdk.org/jdk pull/11229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11229

View PR using the GUI difftool:
$ git pr show -t 11229

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11229.diff

bridgekeeper · 2022-11-18T03:28:41Z

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-11-18T03:31:18Z

@jddarcy The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-11-18T03:34:41Z

Webrevs

test/jdk/java/lang/Class/getModifiers/TestPrimitiveAndArrayModifiers.java

src/java.base/share/classes/java/lang/Class.java

mlchung

Same change should also be applied to Class::accessFlags?

src/java.base/share/classes/java/lang/Class.java

mlchung · 2022-11-18T17:42:41Z

src/java.base/share/classes/java/lang/Class.java

+     * If this {@code Class} object represents a primitive type or
+     * void, its {@code public}, {@code abstract}, and {@code final}
+     * modifiers are always {@code true}.
+     * For class objects representing void, primitive types, and


Suggested change

* For class objects representing void, primitive types, and

* For {@code Class} objects representing void, primitive types, and

Yes; I'll make the corresponding change to accessFlags() and its tests; updated PR and CSR momentarily. Thanks.

openjdk · 2022-11-18T18:25:19Z

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296743: Tighten Class.getModifiers spec for array classes

Reviewed-by: rriggs, mchung, heidinga

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

3a15e84: 8297258: Typo in java -help referencing -disable-@files instead of --disable-@files
43ce047: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout
035eaee: 8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM
59a308b: 8296632: Write a test to verify the content change of TextArea sends TextEvent
11fc65f: 8023562: [TEST_BUG] java/awt/Mouse/EnterExitEvents/DragWindowTest.java failed on ubuntu 13 and mac 10.11
2c692aa: 8297088: Update LCMS to 2.14
9b4e0e8: 8297080: Remove com/sun/jdi/NashornPopFrameTest.java from the problem list
3272954: 8297083: Remove vmTestbase/nsk/jvmti/GetAllThreads/allthr001 from problem list
c4b6920: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java
f34ca80: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
... and 8 more: https://git.openjdk.org/jdk/compare/373e52c0ab0d4fd3c6b18e67e0c46d1d1f0ac91e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2022-11-18T18:25:24Z

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296743: Tighten Class.getModifiers spec for array classes

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

c4b6920: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java
f34ca80: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
13158cb: 8293041: --disable-@files option doesn't work and cause an error
761a4f4: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
2f2d404: 8297129: Inflater documentation refers to 'deflate' methods
dd18d76: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
2b6dbc7: 8293856: AArch64: Remove clear_inst_mark from aarch64_enc_java_dynamic_call
2f063b8: 8296846: Minor cleanup of some dead code in Flow.java
ab6b7ef: 8296901: Do not create unsigned certificate and CRL
7b3984c: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mlchung

Looks good.

mlchung · 2022-11-18T18:35:58Z

src/java.base/share/classes/java/lang/Class.java

+     * </ul>
+     *  If this {@code Class} object represents a primitive type or
+     *  void, the flags are {@code PUBLIC}, {@code ABSTRACT}, and
+     *  {@code FINAL}.


Nit: extra space after * in L1344-1346.

DanHeidinga

looks good. Thanks Joe

pavelrappo · 2022-11-18T19:40:40Z

Feeling stupid for asking this, but does it make any sense to keep the order of modifiers "blessed" in text and tests?

public protected private
abstract static final transient
volatile synchronized native strictfp

liach · 2022-11-18T20:29:54Z

In the new paragraph, the modifiers are sorted by their significance in bitwise representation, from least to most significant. Though interface bit comes between final and abstract. However, in the older previous paragraph, they are sorted by the blessed order in source (suggested by JLS). We can consider whether to unify these orders to both blessed or bitwise.

jddarcy · 2022-11-18T21:40:07Z

Feeling stupid for asking this, but does it make any sense to keep the order of modifiers "blessed" in text and tests?

public protected private abstract static final transient volatile synchronized native strictfp

Will address nit before pushing; thanks.

jddarcy · 2022-11-18T21:50:32Z

/integrate

openjdk · 2022-11-18T21:52:11Z

Going to push as commit 6fd1442.
Since your change was applied there have been 18 commits pushed to the master branch:

3a15e84: 8297258: Typo in java -help referencing -disable-@files instead of --disable-@files
43ce047: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout
035eaee: 8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM
59a308b: 8296632: Write a test to verify the content change of TextArea sends TextEvent
11fc65f: 8023562: [TEST_BUG] java/awt/Mouse/EnterExitEvents/DragWindowTest.java failed on ubuntu 13 and mac 10.11
2c692aa: 8297088: Update LCMS to 2.14
9b4e0e8: 8297080: Remove com/sun/jdi/NashornPopFrameTest.java from the problem list
3272954: 8297083: Remove vmTestbase/nsk/jvmti/GetAllThreads/allthr001 from problem list
c4b6920: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java
f34ca80: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
... and 8 more: https://git.openjdk.org/jdk/compare/373e52c0ab0d4fd3c6b18e67e0c46d1d1f0ac91e...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-11-18T21:52:27Z

@jddarcy Pushed as commit 6fd1442.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8296743: Tighten Class.getModifiers spec for array classes

3321b08

openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Nov 18, 2022

openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 18, 2022

RogerRiggs approved these changes Nov 18, 2022

View reviewed changes

test/jdk/java/lang/Class/getModifiers/TestPrimitiveAndArrayModifiers.java Outdated Show resolved Hide resolved

DanHeidinga reviewed Nov 18, 2022

View reviewed changes

src/java.base/share/classes/java/lang/Class.java Show resolved Hide resolved

Respond to review feedback.

dd1f300

mlchung reviewed Nov 18, 2022

View reviewed changes

Respond to review feedback.

375c260

openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 18, 2022

openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2022

mlchung approved these changes Nov 18, 2022

View reviewed changes

DanHeidinga approved these changes Nov 18, 2022

View reviewed changes

Address review feedback.

63cf2df

openjdk bot added the integrated Pull request has been integrated label Nov 18, 2022

openjdk bot closed this Nov 18, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2022

jddarcy deleted the JDK-8296743 branch June 10, 2023 20:12

JDK-8296743: Tighten Class.getModifiers spec for array classes #11229

JDK-8296743: Tighten Class.getModifiers spec for array classes #11229

jddarcy commented Nov 18, 2022 •

edited by openjdk bot

bridgekeeper bot commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

mlbridge bot commented Nov 18, 2022 •

edited

mlchung left a comment

mlchung Nov 18, 2022

jddarcy Nov 18, 2022 •

edited

openjdk bot commented Nov 18, 2022 •

edited

openjdk bot commented Nov 18, 2022

mlchung left a comment

mlchung Nov 18, 2022

DanHeidinga left a comment

pavelrappo commented Nov 18, 2022

liach commented Nov 18, 2022 •

edited

jddarcy commented Nov 18, 2022

jddarcy commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

	* For class objects representing void, primitive types, and
	* For {@code Class} objects representing void, primitive types, and

JDK-8296743: Tighten Class.getModifiers spec for array classes #11229

JDK-8296743: Tighten Class.getModifiers spec for array classes #11229

Conversation

jddarcy commented Nov 18, 2022 • edited by openjdk bot

Progress

Issues

Reviewers

Reviewing

bridgekeeper bot commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

mlbridge bot commented Nov 18, 2022 • edited

Webrevs

mlchung left a comment

Choose a reason for hiding this comment

mlchung Nov 18, 2022

Choose a reason for hiding this comment

jddarcy Nov 18, 2022 • edited

Choose a reason for hiding this comment

openjdk bot commented Nov 18, 2022 • edited

openjdk bot commented Nov 18, 2022

mlchung left a comment

Choose a reason for hiding this comment

mlchung Nov 18, 2022

Choose a reason for hiding this comment

DanHeidinga left a comment

Choose a reason for hiding this comment

pavelrappo commented Nov 18, 2022

liach commented Nov 18, 2022 • edited

jddarcy commented Nov 18, 2022

jddarcy commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

jddarcy commented Nov 18, 2022 •

edited by openjdk bot

mlbridge bot commented Nov 18, 2022 •

edited

jddarcy Nov 18, 2022 •

edited

openjdk bot commented Nov 18, 2022 •

edited

liach commented Nov 18, 2022 •

edited