Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8296945: PublicMethodsTest is slow due to dependency verification with debug builds #11234

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 18, 2022

As discussed in https://bugs.openjdk.org/browse/JDK-8296945 , let us switch off VerifyDependencies in this test because of slow machines when (fast)debug builds are used, the test sometimes times out after the JDK-8266074 Vtable-based CHA implementation implementation came in.
Same has been done for other tests with similar issues, see 8268227: java/foreign/TestUpcall.java still times out .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296945: PublicMethodsTest is slow due to dependency verification with debug builds

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11234/head:pull/11234
$ git checkout pull/11234

Update a local copy of the PR:
$ git checkout pull/11234
$ git pull https://git.openjdk.org/jdk pull/11234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11234

View PR using the GUI difftool:
$ git pr show -t 11234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11234.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@MBaesken The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning off the dependency verification for this test is okay.

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296945: PublicMethodsTest is slow due to dependency verification with debug builds

Reviewed-by: mchung, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 544e317: 8059632: Method reference compilation uses incorrect qualifying type
  • 651e547: 8297217: Incorrect generation name in the heap verification log message with Serial GC
  • dd55310: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
  • 3ea8971: 8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp
  • 0a3b0fc: 8296784: Provide clean mallinfo/mallinfo2 wrapper for Linux glibc platforms
  • 7b3d581: 8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList
  • 251e065: 8296764: NMT: reduce loads in os::malloc
  • 0845b39: 8296796: Provide clean, platform-agnostic interface to C-heap trimming
  • c50a904: 8297195: AWTAccessor and SwingAccessor should avoid double racy reads from non-volatile fields
  • 906f1ca: 8292317: Missing null check for Iterator.forEachRemaining implementations
  • ... and 19 more: https://git.openjdk.org/jdk/compare/2b6dbc71d8ad2843d3871c7d042313cd71d6d700...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2022
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@MBaesken
Copy link
Member Author

Hi Mandy and Tobias, thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

Going to push as commit bcc6b12.
Since your change was applied there have been 30 commits pushed to the master branch:

  • fc61658: 8294591: Fix cast-function-type warning in TemplateTable
  • 544e317: 8059632: Method reference compilation uses incorrect qualifying type
  • 651e547: 8297217: Incorrect generation name in the heap verification log message with Serial GC
  • dd55310: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
  • 3ea8971: 8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp
  • 0a3b0fc: 8296784: Provide clean mallinfo/mallinfo2 wrapper for Linux glibc platforms
  • 7b3d581: 8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList
  • 251e065: 8296764: NMT: reduce loads in os::malloc
  • 0845b39: 8296796: Provide clean, platform-agnostic interface to C-heap trimming
  • c50a904: 8297195: AWTAccessor and SwingAccessor should avoid double racy reads from non-volatile fields
  • ... and 20 more: https://git.openjdk.org/jdk/compare/2b6dbc71d8ad2843d3871c7d042313cd71d6d700...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022
@openjdk openjdk bot closed this Nov 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@MBaesken Pushed as commit bcc6b12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants