New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8296945: PublicMethodsTest is slow due to dependency verification with debug builds #11234
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turning off the dependency verification for this test is okay.
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
Hi Mandy and Tobias, thanks for the reviews ! /integrate |
Going to push as commit bcc6b12.
Your commit was automatically rebased without conflicts. |
As discussed in https://bugs.openjdk.org/browse/JDK-8296945 , let us switch off VerifyDependencies in this test because of slow machines when (fast)debug builds are used, the test sometimes times out after the JDK-8266074 Vtable-based CHA implementation implementation came in.
Same has been done for other tests with similar issues, see 8268227: java/foreign/TestUpcall.java still times out .
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11234/head:pull/11234
$ git checkout pull/11234
Update a local copy of the PR:
$ git checkout pull/11234
$ git pull https://git.openjdk.org/jdk pull/11234/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11234
View PR using the GUI difftool:
$ git pr show -t 11234
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11234.diff