Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java #11237

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Nov 18, 2022

This is follow up of #11158 (comment)

I have added empty paint() and update() methods back for the frame in this test.
Ran the test 20 times in our CI machines on all platforms. It failed once in Linux machine and image dump showed nothing was drawn.

Added robot.waitForIdle() after frame.resize() also so that system-triggered repaint can be finished after resize of the frame. With this update i don't see this test failing on all platforms in our CI even when run for 100 times.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • JDK-8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11237/head:pull/11237
$ git checkout pull/11237

Update a local copy of the PR:
$ git checkout pull/11237
$ git pull https://git.openjdk.org/jdk pull/11237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11237

View PR using the GUI difftool:
$ git pr show -t 11237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11237.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@jayathirthrao The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

@jayathirthrao
Copy link
Member Author

@mrserb please take a look

@jayathirthrao
Copy link
Member Author

/issue add JDK-8297153

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@jayathirthrao
Adding additional issue to issue list: 8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again.

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 45d1807: 6312651: Compiler should only use verified interface types for optimization
  • bcc6b12: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
  • fc61658: 8294591: Fix cast-function-type warning in TemplateTable
  • 544e317: 8059632: Method reference compilation uses incorrect qualifying type
  • 651e547: 8297217: Incorrect generation name in the heap verification log message with Serial GC
  • dd55310: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
  • 3ea8971: 8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp
  • 0a3b0fc: 8296784: Provide clean mallinfo/mallinfo2 wrapper for Linux glibc platforms
  • 7b3d581: 8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList
  • 251e065: 8296764: NMT: reduce loads in os::malloc
  • ... and 23 more: https://git.openjdk.org/jdk/compare/2f063b86fba785bce03f9f9b3092046be188b84c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2022
@jayathirthrao
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

Going to push as commit 3c09498.
Since your change was applied there have been 33 commits pushed to the master branch:

  • 45d1807: 6312651: Compiler should only use verified interface types for optimization
  • bcc6b12: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
  • fc61658: 8294591: Fix cast-function-type warning in TemplateTable
  • 544e317: 8059632: Method reference compilation uses incorrect qualifying type
  • 651e547: 8297217: Incorrect generation name in the heap verification log message with Serial GC
  • dd55310: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
  • 3ea8971: 8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp
  • 0a3b0fc: 8296784: Provide clean mallinfo/mallinfo2 wrapper for Linux glibc platforms
  • 7b3d581: 8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList
  • 251e065: 8296764: NMT: reduce loads in os::malloc
  • ... and 23 more: https://git.openjdk.org/jdk/compare/2f063b86fba785bce03f9f9b3092046be188b84c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022
@openjdk openjdk bot closed this Nov 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@jayathirthrao Pushed as commit 3c09498.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants