Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate #11239

Closed
wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Nov 18, 2022

Hi,

In the vector type predicate matching process of riscv, n->bottom_type()->is_vect()->element_basic_type() is used in some places to get the data type, and Matcher::vector_element_basic_type(n) is used in some places to get the data type, In fact, Matcher::vector_element_basic_type(n) is the function encapsulation form of n->bottom_type()->is_vect()->element_basic_type(), here Matcher::vector_element_basic_type(n) is used uniformly to get the data type.

Please take a look and have some reviews. Thanks a lot.

Testing:

  • hotspot and jdk tier1 without new failures (release with UseRVV on QEMU)
  • test/jdk/jdk/incubator/vector/* (fastdebug/release with UseRVV on QEMU)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11239/head:pull/11239
$ git checkout pull/11239

Update a local copy of the PR:
$ git checkout pull/11239
$ git pull https://git.openjdk.org/jdk pull/11239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11239

View PR using the GUI difftool:
$ git pr show -t 11239

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11239.diff

@zifeihan zifeihan changed the title Unifying predicates for vector type matching in c2 8297238: RISC-V: Unifying predicates for vector type matching in c2 Nov 18, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@zifeihan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

Copy link
Member

@DingliZhang DingliZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the cleanup.

@openjdk
Copy link

openjdk bot commented Nov 19, 2022

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate

Reviewed-by: dzhang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • c50a904: 8297195: AWTAccessor and SwingAccessor should avoid double racy reads from non-volatile fields
  • 906f1ca: 8292317: Missing null check for Iterator.forEachRemaining implementations
  • 0ec575a: 8297289: problem list runtime/vthread/RedefineClass.java and TestObjectAllocationSampleEvent.java
  • dcb8375: 8245246: Deprecate -profile option in javac
  • 52494df: 8290845: Consider an alternative item separator for multi-item option values
  • c56c69e: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
  • 6fd1442: 8296743: Tighten Class.getModifiers spec for array classes
  • 3a15e84: 8297258: Typo in java -help referencing -disable-@files instead of --disable-@files
  • 43ce047: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout
  • 035eaee: 8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM
  • ... and 13 more: https://git.openjdk.org/jdk/compare/ab6b7ef98800bee5e87e39a616af642874eb154a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 19, 2022
@RealFYang
Copy link
Member

RealFYang commented Nov 19, 2022

PS: I think it should be more specific to change the title of the JBS issue to something like: "RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate"

@zifeihan zifeihan changed the title 8297238: RISC-V: Unifying predicates for vector type matching in c2 8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate Nov 19, 2022
@zifeihan
Copy link
Member Author

@RealFYang @DingliZhang Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 19, 2022
@openjdk
Copy link

openjdk bot commented Nov 19, 2022

@zifeihan
Your change (at version 4f74fa2) is now ready to be sponsored by a Committer.

@zifeihan
Copy link
Member Author

PS: I think it should be more specific to change the title of the JBS issue to something like: "RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate"

Thanks, done.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

Going to push as commit e420661.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 891c706: 8295276: AArch64: Add backend support for half float conversion intrinsics
  • 3c09498: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • 45d1807: 6312651: Compiler should only use verified interface types for optimization
  • bcc6b12: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
  • fc61658: 8294591: Fix cast-function-type warning in TemplateTable
  • 544e317: 8059632: Method reference compilation uses incorrect qualifying type
  • 651e547: 8297217: Incorrect generation name in the heap verification log message with Serial GC
  • dd55310: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
  • 3ea8971: 8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp
  • 0a3b0fc: 8296784: Provide clean mallinfo/mallinfo2 wrapper for Linux glibc platforms
  • ... and 26 more: https://git.openjdk.org/jdk/compare/ab6b7ef98800bee5e87e39a616af642874eb154a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022
@openjdk openjdk bot closed this Nov 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@RealFYang @zifeihan Pushed as commit e420661.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the JDK-8297238 branch November 21, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants