8293584: CodeCache::old_nmethods_do incorrectly filters is_unloading nmethods

[coleenp]

I fixed the code to also include is_unloading nmethods. I couldn't write a dedicated test for this.
Tested with tier1-4,6. Also tried to reproduce another redefinition bug with this change, which didn't reproduce, but not caused by this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293584: CodeCache::old_nmethods_do incorrectly filters is_unloading nmethods

Reviewers

• Erik Österlund (@fisk - Reviewer) ⚠️ Review applies to de0a72c9
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11243/head:pull/11243
$ git checkout pull/11243

Update a local copy of the PR:
$ git checkout pull/11243
$ git pull https://git.openjdk.org/jdk pull/11243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11243

View PR using the GUI difftool:
$ git pr show -t 11243

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11243.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (91dc37be)
• 00: Full (de0a72c9)

[fisk]

Looks good.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293584: CodeCache::old_nmethods_do incorrectly filters is_unloading nmethods

Reviewed-by: eosterlund, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 0ec575a: 8297289: problem list runtime/vthread/RedefineClass.java and TestObjectAllocationSampleEvent.java
• dcb8375: 8245246: Deprecate -profile option in javac
• 52494df: 8290845: Consider an alternative item separator for multi-item option values
• c56c69e: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
• 6fd1442: 8296743: Tighten Class.getModifiers spec for array classes
• 3a15e84: 8297258: Typo in java -help referencing -disable-@files instead of --disable-@files
• 43ce047: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout
• 035eaee: 8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM
• 59a308b: 8296632: Write a test to verify the content change of TextArea sends TextEvent
• 11fc65f: 8023562: [TEST_BUG] java/awt/Mouse/EnterExitEvents/DragWindowTest.java failed on ubuntu 13 and mac 10.11
• ... and 4 more: https://git.openjdk.org/jdk/compare/f34ca80167eb5e34951a24e029a0e84bdabfd883...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Would be nice to have a comment here to explain why is_unloaded nmethods are included in scan.

[coleenp]

Thanks @fisk. I also added a comment @vnkozlov. Please review for accuracy.

[vnkozlov]

Good.

[coleenp]

Thanks for reviewing!
/integrate

[openjdk]

Going to push as commit 0800813.
Since your change was applied there have been 34 commits pushed to the master branch:

• 16ab754: 8196018: java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java fails
• 8b8d848: 8293422: DWARF emitted by Clang cannot be parsed
• 59d8f67: 8297265: G1: Remove unnecessary null-check in RebuildCodeRootClosure::do_code_blob
• 2fc340a: 8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar
• e420661: 8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate
• 891c706: 8295276: AArch64: Add backend support for half float conversion intrinsics
• 3c09498: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
• 45d1807: 6312651: Compiler should only use verified interface types for optimization
• bcc6b12: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
• fc61658: 8294591: Fix cast-function-type warning in TemplateTable
• ... and 24 more: https://git.openjdk.org/jdk/compare/f34ca80167eb5e34951a24e029a0e84bdabfd883...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 0800813.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.