-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList #11247
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add nio |
@AlanBateman |
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Thanks @LanceAndersen. |
@AlanBateman Pushed as commit 7b3d581. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
java/nio/channels/FileChannel/FileExtensionAndMap.java was excluded for a long time because it required too many resources. It was re-enabled recently via JDK-8249693 but it's back causing problems again add adding up to 40 minutes to jdk/:tier2_part2. I'd like to exclude it again until the test can be re-written.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11247/head:pull/11247
$ git checkout pull/11247
Update a local copy of the PR:
$ git checkout pull/11247
$ git pull https://git.openjdk.org/jdk pull/11247/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11247
View PR using the GUI difftool:
$ git pr show -t 11247
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11247.diff