Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList #11247

Closed
wants to merge 1 commit into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Nov 19, 2022

java/nio/channels/FileChannel/FileExtensionAndMap.java was excluded for a long time because it required too many resources. It was re-enabled recently via JDK-8249693 but it's back causing problems again add adding up to 40 minutes to jdk/:tier2_part2. I'd like to exclude it again until the test can be re-written.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11247/head:pull/11247
$ git checkout pull/11247

Update a local copy of the PR:
$ git checkout pull/11247
$ git pull https://git.openjdk.org/jdk pull/11247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11247

View PR using the GUI difftool:
$ git pr show -t 11247

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11247.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2022

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2022

@AlanBateman To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@AlanBateman
Copy link
Contributor Author

/label add nio

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Nov 19, 2022
@openjdk
Copy link

openjdk bot commented Nov 19, 2022

@AlanBateman
The nio label was successfully added.

@AlanBateman AlanBateman marked this pull request as ready for review November 19, 2022 14:53
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 19, 2022

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297293: Add java/nio/channels/FileChannel/FileExtensionAndMap.java to ProblemList

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 251e065: 8296764: NMT: reduce loads in os::malloc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 19, 2022
@AlanBateman
Copy link
Contributor Author

/integrate

@AlanBateman
Copy link
Contributor Author

Thanks @LanceAndersen.

@openjdk
Copy link

openjdk bot commented Nov 19, 2022

Going to push as commit 7b3d581.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 251e065: 8296764: NMT: reduce loads in os::malloc

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 19, 2022
@openjdk openjdk bot closed this Nov 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2022
@openjdk
Copy link

openjdk bot commented Nov 19, 2022

@AlanBateman Pushed as commit 7b3d581.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants