Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion #11250

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 20, 2022

The quality of the cmm library is increased since the bug was reported. This is the request to import the test from the bug description to improve the code coverage.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11250/head:pull/11250
$ git checkout pull/11250

Update a local copy of the PR:
$ git checkout pull/11250
$ git pull https://git.openjdk.org/jdk pull/11250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11250

View PR using the GUI difftool:
$ git pr show -t 11250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11250.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2022

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 20, 2022
@mrserb mrserb marked this pull request as ready for review November 20, 2022 09:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2022

Webrevs

Copy link
Member

@jayathirthrao jayathirthrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Test is verified in CI and passes on all platforms.

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion

Reviewed-by: jdv, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

  • 09ac9eb: 8297533: ProblemList java/io/File/TempDirDoesNotExist.java test failing on windows-x64
  • 5325145: 8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64
  • 91cd8a0: 8297525: jdk/jshell/ToolBasicTest.java fails after JDK-8295984
  • 6dc4d89: 7181214: Need specify SKF translateKey(SecurityKey) method requires instance of PBEKey for PBKDF2 algorithms
  • 2afb4c3: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize
  • 8df3bc4: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
  • 086763a: 8297154: Improve safepoint cleanup logging
  • e6e57fe: 8297507: Update header after JDK-8297230
  • bc59f2a: 8295984: Remove unexpected JShell feature
  • 0d93ab9: 8297000: [jib] Add more friendly warning for proxy issues
  • ... and 51 more: https://git.openjdk.org/jdk/compare/3ea89711e34639fef36b6cc143e37b5133aa80f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2022
Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test locally and tested on all platforms. Looks good

@mrserb
Copy link
Member Author

mrserb commented Nov 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2022

Going to push as commit abeddab.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 09ac9eb: 8297533: ProblemList java/io/File/TempDirDoesNotExist.java test failing on windows-x64
  • 5325145: 8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64
  • 91cd8a0: 8297525: jdk/jshell/ToolBasicTest.java fails after JDK-8295984
  • 6dc4d89: 7181214: Need specify SKF translateKey(SecurityKey) method requires instance of PBEKey for PBKDF2 algorithms
  • 2afb4c3: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize
  • 8df3bc4: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
  • 086763a: 8297154: Improve safepoint cleanup logging
  • e6e57fe: 8297507: Update header after JDK-8297230
  • bc59f2a: 8295984: Remove unexpected JShell feature
  • 0d93ab9: 8297000: [jib] Add more friendly warning for proxy issues
  • ... and 51 more: https://git.openjdk.org/jdk/compare/3ea89711e34639fef36b6cc143e37b5133aa80f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 24, 2022
@openjdk openjdk bot closed this Nov 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@mrserb Pushed as commit abeddab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-6528710 branch January 22, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants