8297342: make LOG=debug is too verbose #11264

magicus · 2022-11-21T14:11:27Z

The debug level of make logging is not really useful, since it spits out a full expansion of all named param macro arguments and their values.

With the NamedParamsMacroTemplate being stable for years, this is seldom useful, and the massive amount of logs drown out everything else.

We should move this debugging to the trace level.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8297342: make LOG=debug is too verbose

Reviewers

Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11264/head:pull/11264
$ git checkout pull/11264

Update a local copy of the PR:
$ git checkout pull/11264
$ git pull https://git.openjdk.org/jdk pull/11264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11264

View PR using the GUI difftool:
$ git pr show -t 11264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11264.diff

bridgekeeper · 2022-11-21T14:12:43Z

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

magicus · 2022-11-21T14:15:02Z

Without this fix, all debug logs would start by a massive amount of

Building target 'jdk' in configuration 'macosx-aarch64'
make[2]: Entering directory '/Users/ihse/git/jdk-DOH/open'
SetupTarget buildtools-langtools  
 [2] MAKEFILE := ToolsLangtools                                                                                                                                                                                            
SetupTarget interim-langtools  
 [2] MAKEFILE := CompileInterimLangtools                                                                                                                                                                                            
SetupTarget interim-tzdb  
 [2] MAKEFILE := CopyInterimTZDB                                                                                                                                                                                            
SetupTarget buildtools-jdk  
 [2] MAKEFILE := CompileToolsJdk  
 [3] DEPS := interim-langtools interim-tzdb                                                                                                                                                                                          
SetupTarget buildtools-modules  
 [2] MAKEFILE := CompileModuleTools                                                                                                                                                                                            
SetupTarget buildtools-hotspot  
 [2] MAKEFILE := CompileToolsHotspot

listing all make targets from Main.gmk.

With this fix, the log starts

Building target 'jdk' in configuration 'macosx-aarch64-server-release'
gmake[2]: Entering directory '/Users/ihse/git/jdk-DOH/open'
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ToolsLangtools.gmk  )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f CopyInterimTZDB.gmk  )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/java.base MODULE=java.base MAKEFILE_PREFIX=Copy )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f CompileToolsHotspot.gmk  )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/java.desktop MODULE=java.desktop MAKEFILE_PREFIX=Copy )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/java.logging MODULE=java.logging MAKEFILE_PREFIX=Copy )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/jdk.accessibility MODULE=jdk.accessibility MAKEFILE_PREFIX=Copy )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/jdk.management.agent MODULE=jdk.management.agent MAKEFILE_PREFIX=Copy )
gmake[3]: Entering directory '/Users/ihse/git/jdk-DOH/open/make'

which is much more helpful in showing how the build system starts collecting initial dependencies.

openjdk · 2022-11-21T14:16:29Z

@magicus The following label will be automatically applied to this pull request:

build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-11-21T14:20:20Z

Webrevs

00: Full (837c624f)

openjdk · 2022-11-21T14:41:36Z

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297342: make LOG=debug is too verbose

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

d0a7938: 8286575: Document how properties in java.security are parsed
5c33454: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call
0800813: 8293584: CodeCache::old_nmethods_do incorrectly filters is_unloading nmethods
16ab754: 8196018: java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java fails
8b8d848: 8293422: DWARF emitted by Clang cannot be parsed
59d8f67: 8297265: G1: Remove unnecessary null-check in RebuildCodeRootClosure::do_code_blob
2fc340a: 8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

magicus · 2022-11-21T15:11:22Z

/integrate

openjdk · 2022-11-21T15:13:20Z

Going to push as commit 0ac0148.
Since your change was applied there have been 7 commits pushed to the master branch:

d0a7938: 8286575: Document how properties in java.security are parsed
5c33454: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call
0800813: 8293584: CodeCache::old_nmethods_do incorrectly filters is_unloading nmethods
16ab754: 8196018: java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java fails
8b8d848: 8293422: DWARF emitted by Clang cannot be parsed
59d8f67: 8297265: G1: Remove unnecessary null-check in RebuildCodeRootClosure::do_code_blob
2fc340a: 8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar

Your commit was automatically rebased without conflicts.

openjdk · 2022-11-21T15:13:42Z

@magicus Pushed as commit 0ac0148.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8297342: make LOG=debug is too verbose

837c624

openjdk bot added the rfr Pull request is ready for review label Nov 21, 2022

openjdk bot added the build build-dev@openjdk.org label Nov 21, 2022

erikj79 approved these changes Nov 21, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2022

openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022

openjdk bot closed this Nov 21, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022

magicus deleted the better-debug-log branch November 21, 2022 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8297342: make LOG=debug is too verbose #11264

8297342: make LOG=debug is too verbose #11264

Uh oh!

magicus commented Nov 21, 2022 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Nov 21, 2022

Uh oh!

magicus commented Nov 21, 2022

Uh oh!

openjdk bot commented Nov 21, 2022

Uh oh!

mlbridge bot commented Nov 21, 2022

Uh oh!

openjdk bot commented Nov 21, 2022

Uh oh!

magicus commented Nov 21, 2022

Uh oh!

openjdk bot commented Nov 21, 2022

Uh oh!

openjdk bot commented Nov 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

8297342: make LOG=debug is too verbose #11264

8297342: make LOG=debug is too verbose #11264

Uh oh!

Conversation

magicus commented Nov 21, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Nov 21, 2022

Uh oh!

magicus commented Nov 21, 2022

Uh oh!

openjdk bot commented Nov 21, 2022

Uh oh!

mlbridge bot commented Nov 21, 2022

Webrevs

Uh oh!

openjdk bot commented Nov 21, 2022

Uh oh!

magicus commented Nov 21, 2022

Uh oh!

openjdk bot commented Nov 21, 2022

Uh oh!

openjdk bot commented Nov 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

magicus commented Nov 21, 2022 •

edited by openjdk bot

Loading