-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8297348: make CONF=xxx should match if xxx is an exact match #11269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
|
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit cd6a203.
Your commit was automatically rebased without conflicts. |
A typical use case for multiple configurations is that you have a release configuration (say
linux-x64) and a debug configuration (saylinux-x64-debug). You can now easily select the debug configuration withCONF=debug, or both configurations withCONF=, but there is no way to select just the release configuration. Instead, workarounds usingSPECorCONF_NAME(which always does an exact match) is needed.Instead, we should modify the behavior of
CONFslightly, so if it gets an exact match, it should behave likeCONF_NAMEand select just that configurations.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11269/head:pull/11269$ git checkout pull/11269Update a local copy of the PR:
$ git checkout pull/11269$ git pull https://git.openjdk.org/jdk pull/11269/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11269View PR using the GUI difftool:
$ git pr show -t 11269Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11269.diff