Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8189198: Add "forRemoval = true" to Applet APIs #1127

Closed
wants to merge 8 commits into from

Conversation

andyherrick
Copy link

@andyherrick andyherrick commented Nov 9, 2020


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Integration blocker

 ⚠️ The change requires a CSR request to be approved.

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1127/head:pull/1127
$ git checkout pull/1127

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2020

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@andyherrick
Copy link
Author

andyherrick commented Nov 9, 2020

preliminary changes for JDK-8189198 for evaluation

@openjdk
Copy link

openjdk bot commented Nov 9, 2020

@andyherrick The following labels will be automatically applied to this pull request:

  • 2d
  • awt
  • beans
  • i18n
  • sound
  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d client-libs-dev@openjdk.org swing client-libs-dev@openjdk.org sound client-libs-dev@openjdk.org beans client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org awt client-libs-dev@openjdk.org labels Nov 9, 2020
@andyherrick andyherrick reopened this Nov 12, 2020
@andyherrick andyherrick marked this pull request as ready for review Nov 12, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2020

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 12, 2020

The following field, which is currently deprecated (not for removal) should probably also be marked as deprecated for removal::

javax.naming.Context:
    static final String APPLET

The CSR and JEP should be updated accordingly.

Also, what about the following?

javax.swing.text.html.parser.DTD
    Element applet 	

Copy link
Member

@irisclark irisclark left a comment

Since all APIs in the java.applet package are deprecated "forRemoval = true", consider adding a brief deprecation note to java/applet/package-info.java too.

As an example, when all of the APIs in package java.rmi.activation were similarly deprecated in JDK 15, the following note was added:

https://docs.oracle.com/en/java/javase/15/docs/api/java.rmi/java/rmi/activation/package-summary.html .

Thanks!
Iris

@openjdk
Copy link

openjdk bot commented Nov 12, 2020

@andyherrick This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 12, 2020
@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 12, 2020
@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 13, 2020

@andyherrick can you enter the /csr needed command? I would, but it needs to be done by either the author of the PR or a Reviewer.

@andyherrick
Copy link
Author

andyherrick commented Nov 13, 2020

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Nov 13, 2020
@openjdk
Copy link

openjdk bot commented Nov 13, 2020

@andyherrick this pull request will not be integrated until the CSR request JDK-8189232 for issue JDK-8189198 has been approved.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 13, 2020
@@ -1082,6 +1082,6 @@ public Object removeFromEnvironment(String propName)
*
* @since 1.3
*/
@Deprecated
@Deprecated(since="16", forRemoval=true)
String APPLET = "java.naming.applet";
};
Copy link
Contributor

@AlanBateman AlanBateman Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be since="9" (the deprecation in JDK-8051422 pre-dates the enhanced deprecation work).

Copy link
Member

@kevinrushforth kevinrushforth Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, since it was in fact deprecated in 9.

Copy link
Author

@andyherrick andyherrick Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - changed to since="9" this morning

@@ -36,7 +36,11 @@
* running applets. For example, the applet context could be a Web browser or an
* applet development environment.
* <p>
* The APIs in this package are all deprecated without replacement.
* Deprecated.
* This package has been deprecated and may be removed in a future version of the Java Platform.
Copy link
Member

@kevinrushforth kevinrushforth Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be @deprecated This package .... See java/rmi/activation/package-info.java#L41.

Copy link
Member

@mrserb mrserb Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation description should point to the new API which might be used instead of the deprecated ones. So the text "deprecated without replacement" was intentionally added, it will be good to preserve it.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2020

@andyherrick This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2021

@andyherrick This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!

@bridgekeeper bridgekeeper bot closed this Jan 11, 2021
@andyherrick andyherrick deleted the JDK-8189198 branch Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org beans client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration i18n i18n-dev@openjdk.org rfr Pull request is ready for review sound client-libs-dev@openjdk.org swing client-libs-dev@openjdk.org
6 participants