JDK-8189198: Add "forRemoval = true" to Applet APIs #1127
Conversation
|
👋 Welcome back herrick! A progress list of the required criteria for merging this PR into |
|
preliminary changes for JDK-8189198 for evaluation |
|
@andyherrick The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
The following field, which is currently deprecated (not for removal) should probably also be marked as deprecated for removal:: The CSR and JEP should be updated accordingly. Also, what about the following? |
There was a problem hiding this comment.
Since all APIs in the java.applet package are deprecated "forRemoval = true", consider adding a brief deprecation note to java/applet/package-info.java too.
As an example, when all of the APIs in package java.rmi.activation were similarly deprecated in JDK 15, the following note was added:
https://docs.oracle.com/en/java/javase/15/docs/api/java.rmi/java/rmi/activation/package-summary.html .
Thanks!
Iris
|
@andyherrick This change is no longer ready for integration - check the PR body for details. |
|
@andyherrick can you enter the |
|
/csr |
|
@andyherrick this pull request will not be integrated until the CSR request JDK-8189232 for issue JDK-8189198 has been approved. |
| @Deprecated | ||
| @Deprecated(since="16", forRemoval=true) | ||
| String APPLET = "java.naming.applet"; | ||
| }; |
There was a problem hiding this comment.
Probably should be since="9" (the deprecation in JDK-8051422 pre-dates the enhanced deprecation work).
There was a problem hiding this comment.
Good point, since it was in fact deprecated in 9.
There was a problem hiding this comment.
yes - changed to since="9" this morning
| * <p> | ||
| * The APIs in this package are all deprecated without replacement. | ||
| * Deprecated. | ||
| * This package has been deprecated and may be removed in a future version of the Java Platform. |
There was a problem hiding this comment.
That should be @deprecated This package .... See java/rmi/activation/package-info.java#L41.
There was a problem hiding this comment.
The deprecation description should point to the new API which might be used instead of the deprecated ones. So the text "deprecated without replacement" was intentionally added, it will be good to preserve it.
|
@andyherrick This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@andyherrick This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! |
6 participants
Progress
Testing
Integration blocker
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1127/head:pull/1127$ git checkout pull/1127