Skip to content

JDK-8189198: Add "forRemoval = true" to Applet APIs #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

JDK-8189198: Add "forRemoval = true" to Applet APIs #1127

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ca19ac
JDK-8189198: Add "forRemoval = true" to Applet APIs
andyherrick Nov 9, 2020
cba3dc5
JDK-8189198: Add "forRemoval = true" to Applet APIs
andyherrick Nov 9, 2020
3119588
JDK-8189198: Add "forRemoval = true" to Applet APIs
andyherrick Nov 9, 2020
a74deee
Merge branch 'master' into JDK-8189198
andyherrick Nov 12, 2020
877c8e7
Merge branch 'master' into JDK-8189198
andyherrick Nov 12, 2020
d9850cd
JDK-8189198: Add "forRemoval = true" to Applet APIs
andyherrick Nov 12, 2020
c6ea771
JDK-8189198: Add "forRemoval = true" to Applet APIs
andyherrick Nov 13, 2020
bc781be
JDK-8189198: Add "forRemoval = true" to Applet APIs
andyherrick Nov 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/java.desktop/share/classes/java/applet/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@
* running applets. For example, the applet context could be a Web browser or an
* applet development environment.
* <p>
* The APIs in this package are all deprecated without replacement.
* Deprecated.
* This package has been deprecated and may be removed in a future version of the Java Platform.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be @deprecated This package .... See java/rmi/activation/package-info.java#L41.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation description should point to the new API which might be used instead of the deprecated ones. So the text "deprecated without replacement" was intentionally added, it will be good to preserve it.

* All of the classes and interfaces in this package have been terminally deprecated.
* There is no replacement.
* Users are advised to migrate their applications to other technologies.
*
* @since 1.0
*/
Expand Down
2 changes: 1 addition & 1 deletion src/java.naming/share/classes/javax/naming/Context.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,6 +1082,6 @@ public Object removeFromEnvironment(String propName)
*
* @since 1.3
*/
@Deprecated(since="16", forRemoval=true)
@Deprecated(since="9", forRemoval=true)
String APPLET = "java.naming.applet";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be since="9" (the deprecation in JDK-8051422 pre-dates the enhanced deprecation work).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, since it was in fact deprecated in 9.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - changed to since="9" this morning