Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8189198: Add "forRemoval = true" to Applet APIs #1127

Closed
wants to merge 8 commits into from
@@ -36,7 +36,11 @@
* running applets. For example, the applet context could be a Web browser or an
* applet development environment.
* <p>
* The APIs in this package are all deprecated without replacement.
* Deprecated.
* This package has been deprecated and may be removed in a future version of the Java Platform.
Copy link
Member

@kevinrushforth kevinrushforth Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be @deprecated This package .... See java/rmi/activation/package-info.java#L41.

Copy link
Member

@mrserb mrserb Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation description should point to the new API which might be used instead of the deprecated ones. So the text "deprecated without replacement" was intentionally added, it will be good to preserve it.

* All of the classes and interfaces in this package have been terminally deprecated.
* There is no replacement.
* Users are advised to migrate their applications to other technologies.
*
* @since 1.0
*/
@@ -1082,6 +1082,6 @@ public Object removeFromEnvironment(String propName)
*
* @since 1.3
*/
@Deprecated(since="16", forRemoval=true)
@Deprecated(since="9", forRemoval=true)
String APPLET = "java.naming.applet";
};
Copy link
Contributor

@AlanBateman AlanBateman Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be since="9" (the deprecation in JDK-8051422 pre-dates the enhanced deprecation work).

Copy link
Member

@kevinrushforth kevinrushforth Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, since it was in fact deprecated in 9.

Copy link
Author

@andyherrick andyherrick Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - changed to since="9" this morning