Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize #11275

Closed
wants to merge 4 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Nov 21, 2022

Could I have a review of a PR that fixes so event data is kept in the disk repository if max age or max size have been set. This is similar implementation as RecordingStream:

public void setMaxSize(long maxSize) {

I also fixed a problem where chunks may we written out of order in the dump file and disk chunks not being released properly in case of an IOException. To make the code easier to understand, the code uses more logical methods when interacting with the Deque , such as peekLast(), pollLast() and addFirst().

Testing: 100 * test/jdk/jdk/jfr/jmx/stream/TestRemoteDump.java + 1 * test/jdk/jdk/jfr/

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11275/head:pull/11275
$ git checkout pull/11275

Update a local copy of the PR:
$ git checkout pull/11275
$ git pull https://git.openjdk.org/jdk pull/11275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11275

View PR using the GUI difftool:
$ git pr show -t 11275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11275.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Nov 21, 2022
@egahlin egahlin changed the title JFR: RemoteRecordingStream doesn't respekt setMaxAge and setMaxSize 8297338: JFR: RemoteRecordingStream doesn't respekt setMaxAge and setMaxSize Nov 21, 2022
@egahlin
Copy link
Member Author

egahlin commented Nov 21, 2022

/csr

@egahlin
Copy link
Member Author

egahlin commented Nov 21, 2022

/csr unneeded

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@egahlin has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@egahlin please create a CSR request for issue JDK-8297338 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@egahlin determined that a CSR request is not needed for this pull request.

@egahlin egahlin marked this pull request as ready for review November 21, 2022 17:54
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2022

Webrevs

@egahlin egahlin changed the title 8297338: JFR: RemoteRecordingStream doesn't respekt setMaxAge and setMaxSize 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize Nov 21, 2022
@egahlin egahlin marked this pull request as draft November 23, 2022 12:50
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2022
@egahlin egahlin marked this pull request as ready for review November 23, 2022 17:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 23, 2022
@egahlin
Copy link
Member Author

egahlin commented Nov 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit 2afb4c3.
Since your change was applied there have been 44 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 23, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@egahlin Pushed as commit 2afb4c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants