Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297435: Remove unused CompactibleSpaceClosure #11290

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 22, 2022

Trivial removing of dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11290/head:pull/11290
$ git checkout pull/11290

Update a local copy of the PR:
$ git checkout pull/11290
$ git pull https://git.openjdk.org/jdk pull/11290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11290

View PR using the GUI difftool:
$ git pr show -t 11290

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11290.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8297435 8297435: Remove unused CompactibleSpaceClosure Nov 22, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial.

Thanks.

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297435: Remove unused CompactibleSpaceClosure

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 09f70da: 8296265: Use modern HTML in the JVMTI spec
  • e661c5a: 8296323: JVMTI can_support_virtual_threads not available for agents loaded into running VM
  • 974cb83: 8297310: Remove unimplemented HeapInspection::iterate_over_heap
  • e174558: 8296742: Illegal X509 Extension should not be created
  • a6c418e: 8297168: Provide a bulk OopHandle release mechanism with the ServiceThread
  • 4a544bb: 8297091: New langtools test jdk/javadoc/doclet/testValueTag/TestValueFormats.java fails on machines with unexpected number format
  • b6dddf4: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails
  • 260e4dc: 8295011: EC point multiplication improvement for secp256r1
  • fb6c992: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
  • ccc6e16: 8291067: macOS should use O_CLOEXEC instead of FD_CLOEXEC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2022
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit f4b5065.
Since your change was applied there have been 16 commits pushed to the master branch:

  • bde0e35: 8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64
  • f26bd4e: 8297350: Update JMH devkit to 1.36
  • 470f342: 8296904: Improve handling of macos xcode toolchain
  • b4bd287: 8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails
  • 412b436: 6201035: Document NPE for passing null insets to constructors and methods of several javax.swing.border.* classes
  • faf48e6: 8296329: jar validator doesn't account for minor class file version
  • 09f70da: 8296265: Use modern HTML in the JVMTI spec
  • e661c5a: 8296323: JVMTI can_support_virtual_threads not available for agents loaded into running VM
  • 974cb83: 8297310: Remove unimplemented HeapInspection::iterate_over_heap
  • e174558: 8296742: Illegal X509 Extension should not be created
  • ... and 6 more: https://git.openjdk.org/jdk/compare/0ac5b55311222d0531c9cfcec8c74932661b1750...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@albertnetymk Pushed as commit f4b5065.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch November 23, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants