8297481: Create a regression test for JDK-4424517

[srmandal]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297481: Create a regression test for JDK-4424517

Reviewers

• @kiraka42 (no known github.com user name / role)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11313/head:pull/11313
$ git checkout pull/11313

Update a local copy of the PR:
$ git checkout pull/11313
$ git pull https://git.openjdk.org/jdk pull/11313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11313

View PR using the GUI difftool:
$ git pr show -t 11313

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11313.diff

[bridgekeeper]

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @srmandal a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master f26bd4e0e8b68de297a9ff93526cd7fac8668320
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[openjdk]

@srmandal The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (21dfadc5)

[srmandal]

Create a regression test for JDK-4424517
Test is to verify the mapping of various KeyEvents with their KeyLocations
Test triggers events or the various Keys and ensures the KeyLocation mapping to these are accurate.

This review is for migrating tests from a closed test suite to open.

Mach5 Test Results (60 repetitions across 3 platforms) are clean.

[openjdk]

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297481: Create a regression test for JDK-4424517

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• fd910f7: 8297384: Add IR tests for existing idealizations of arithmetic nodes
• cfe5a37: 8297556: Parse::check_interpreter_type fails with assert "must constrain OSR typestate"
• 74d3bac: 8297417: Poly1305IntrinsicFuzzTest fails with tag mismatch exception
• 0ed8b33: 8297385: Remove duplicated null typos in javadoc
• 1fb9dad: 8296419: [REDO] JDK-8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
• 2f47f83: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
• 87d1097: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation
• 390e69a: 8297150: Add a @sealedGraph tag to Reference
• 8effaa8: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections
• ab1f9ff: 8051627: Invariants about java.net.URI resolve and relativize are wrong
• ... and 23 more: https://git.openjdk.org/jdk/compare/f26bd4e0e8b68de297a9ff93526cd7fac8668320...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[srmandal]

/integrate

[openjdk]

@srmandal
Your change (at version 21dfadc) is now ready to be sponsored by a Committer.

[srmandal]

@mrserb Can you please psonsor this request ?

[srmandal]

Any volunteers for sponsoring this PR ?

[prrace]

/sponsor

[openjdk]

Going to push as commit e2d71c0.
Since your change was applied there have been 82 commits pushed to the master branch:

• f4063a3: 8297210: Add a @sealedGraph tag to selected java.desktop classes
• 2084451: 8078471: Backspace does not work in JFileChooser with GTK L&F
• 7af6b4b: 8296012: jshell crashes on mismatched record pattern
• ae5b1f7: 8297685: Typo in NullPointerException description specified by Locale.lookup
• 3ce0042: 8297780: Problem list java/awt/Frame/RestoreToOppositeScreen/RestoreToOppositeScreen.java
• b778cd5: 8295010: Reduce if required in EC limbs operations
• 54e6d6a: 8293488: Add EOR3 backend rule for aarch64 SHA3 extension
• 69ede5b: 8293177: Verify version numbers in legal files
• cd6bebb: 8247645: ChaCha20 intrinsics
• 33587ff: 8292625: jshell crash on "var a = a"
• ... and 72 more: https://git.openjdk.org/jdk/compare/f26bd4e0e8b68de297a9ff93526cd7fac8668320...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace @srmandal Pushed as commit e2d71c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.