8297491: Loom: Stack chunks allocation code uses TLABs even when TLABs are disabled

[shipilev]

See the bug for more details. The apparent fix it to just test for UseTLAB before reaching for TLAB-specific code.

Additional testing:

• Linux x86_64 fastdebug, jdk_loom hotspot_loom
• Linux x86_64 fastdebug, jdk_loom hotspot_loom with -XX:-UseTLAB (a single JFR test failure that does not expect a log of out-of-TLAB-alloc events, to be fixed separately)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297491: Loom: Stack chunks allocation code uses TLABs even when TLABs are disabled

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Axel Boldt-Christmas (@xmas92 - Committer)
• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11317/head:pull/11317
$ git checkout pull/11317

Update a local copy of the PR:
$ git checkout pull/11317
$ git pull https://git.openjdk.org/jdk pull/11317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11317

View PR using the GUI difftool:
$ git pr show -t 11317

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11317.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8db0d991)

[tschatzl]

Lgtm.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297491: Loom: Stack chunks allocation code uses TLABs even when TLABs are disabled

Reviewed-by: tschatzl, aboldtch, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• f4b5065: 8297435: Remove unused CompactibleSpaceClosure
• bde0e35: 8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64
• f26bd4e: 8297350: Update JMH devkit to 1.36
• 470f342: 8296904: Improve handling of macos xcode toolchain
• b4bd287: 8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails
• 412b436: 6201035: Document NPE for passing null insets to constructors and methods of several javax.swing.border.* classes
• faf48e6: 8296329: jar validator doesn't account for minor class file version
• 09f70da: 8296265: Use modern HTML in the JVMTI spec
• e661c5a: 8296323: JVMTI can_support_virtual_threads not available for agents loaded into running VM
• 974cb83: 8297310: Remove unimplemented HeapInspection::iterate_over_heap
• ... and 37 more: https://git.openjdk.org/jdk/compare/544e31722528d12fae0eb19271f85886680801a6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[xmas92]

Lgtm.

Just to note, the MemAllocator and stack chunk refactoring in #11111 / JDK-8296875 fixes this as well.

[shipilev]

Just to note, the MemAllocator and stack chunk refactoring in #11111 / JDK-8296875 fixes this as well.

Nice to know! I would like to go forward with this patch, so that we have something backportable to JDK 19, seeing how this might corrupt memory when -XX:-UseTLAB is set for Loom-using applications.

[shipilev]

GHAs are green. I would like to push it soon to provide a cleaner base for x86_32 Loom port. Any objections?

[stefank]

Go ahead and push.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit f4cf758.
Since your change was applied there have been 62 commits pushed to the master branch:

• 5e5b774: 8296768: Use different explicit claim marks for CLDs in Parallel and Serial GC
• 9c77e41: 8297445: PPC64: Represent Registers as values
• 2f8a5c2: 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check
• abeddab: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion
• 09ac9eb: 8297533: ProblemList java/io/File/TempDirDoesNotExist.java test failing on windows-x64
• 5325145: 8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64
• 91cd8a0: 8297525: jdk/jshell/ToolBasicTest.java fails after JDK-8295984
• 6dc4d89: 7181214: Need specify SKF translateKey(SecurityKey) method requires instance of PBEKey for PBKDF2 algorithms
• 2afb4c3: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize
• 8df3bc4: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
• ... and 52 more: https://git.openjdk.org/jdk/compare/544e31722528d12fae0eb19271f85886680801a6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit f4cf758.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.