Skip to content

8297192: Warning generating API docs for javax.management.MBeanServer: overridden methods do not document exception type #11318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Nov 23, 2022

Simple change to remove these mentions of RuntimeOperationsException.

More notes in the bug, but this seems like a long-standing oversight that has become the only warning in "make docs".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297192: Warning generating API docs for javax.management.MBeanServer: overridden methods do not document exception type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11318/head:pull/11318
$ git checkout pull/11318

Update a local copy of the PR:
$ git checkout pull/11318
$ git pull https://git.openjdk.org/jdk pull/11318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11318

View PR using the GUI difftool:
$ git pr show -t 11318

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11318.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2022

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@kevinjwalls The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 23, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2022

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297192: Warning generating API docs for javax.management.MBeanServer: overridden methods do not document exception type

Reviewed-by: dfuchs, sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 09ac9eb: 8297533: ProblemList java/io/File/TempDirDoesNotExist.java test failing on windows-x64
  • 5325145: 8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64
  • 91cd8a0: 8297525: jdk/jshell/ToolBasicTest.java fails after JDK-8295984
  • 6dc4d89: 7181214: Need specify SKF translateKey(SecurityKey) method requires instance of PBEKey for PBKDF2 algorithms
  • 2afb4c3: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize
  • 8df3bc4: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
  • 086763a: 8297154: Improve safepoint cleanup logging
  • e6e57fe: 8297507: Update header after JDK-8297230
  • bc59f2a: 8295984: Remove unexpected JShell feature
  • 0d93ab9: 8297000: [jib] Add more friendly warning for proxy issues
  • ... and 1 more: https://git.openjdk.org/jdk/compare/f4b5065c37e86f4b2ca26da6ce678febe4a52950...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2022
@kevinjwalls
Copy link
Contributor Author

Thanks Daniel!

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good.
Thanks,
Serguei

@kevinjwalls
Copy link
Contributor Author

Thanks all!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2022

Going to push as commit 070a84c.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 3c4d520: 8296671: [JFR] jdk.ContainerConfiguration event should include host total memory
  • 8b73970: 8296208: AArch64: Enable SHA512 intrinsic by default on supported hardware
  • f4cf758: 8297491: Loom: Stack chunks allocation code uses TLABs even when TLABs are disabled
  • 5e5b774: 8296768: Use different explicit claim marks for CLDs in Parallel and Serial GC
  • 9c77e41: 8297445: PPC64: Represent Registers as values
  • 2f8a5c2: 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check
  • abeddab: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion
  • 09ac9eb: 8297533: ProblemList java/io/File/TempDirDoesNotExist.java test failing on windows-x64
  • 5325145: 8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64
  • 91cd8a0: 8297525: jdk/jshell/ToolBasicTest.java fails after JDK-8295984
  • ... and 8 more: https://git.openjdk.org/jdk/compare/f4b5065c37e86f4b2ca26da6ce678febe4a52950...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 24, 2022
@openjdk openjdk bot closed this Nov 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@kevinjwalls Pushed as commit 070a84c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants