Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293294: Remove dead code in Parse::check_interpreter_type #11325

Closed
wants to merge 1 commit into from

Conversation

MDBijman
Copy link

@MDBijman MDBijman commented Nov 23, 2022

A small cleanup in Parse::check_interpreter_type to remove two dead declarations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293294: Remove dead code in Parse::check_interpreter_type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11325/head:pull/11325
$ git checkout pull/11325

Update a local copy of the PR:
$ git checkout pull/11325
$ git pull https://git.openjdk.org/jdk pull/11325/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11325

View PR using the GUI difftool:
$ git pr show -t 11325

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11325.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 23, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2022

Hi @MDBijman, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user MDBijman" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@MDBijman The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 23, 2022
@MDBijman
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Nov 28, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Nov 28, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2022

Webrevs

Copy link

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@MDBijman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293294: Remove dead code in Parse::check_interpreter_type

Reviewed-by: vlivanov, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 237 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2022
@navyxliu
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@navyxliu The change author (@MDBijman) must issue an integrate command before the integration can be sponsored.

@MDBijman
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@MDBijman
Your change (at version d8bea37) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit 4899d78.
Since your change was applied there have been 268 commits pushed to the master branch:

  • 5459b11: 8297033: G1: Improve logging for Remembered Sets
  • c6156f9: 8297561: Redundant index check in String.offsetByCodePoints()
  • eec24aa: 8295350: JFR: Add stop methods for recording streams
  • 9430f3e: 8297934: [BACKOUT] Compiler should only use verified interface types for optimization
  • 2cb64a7: 8294943: Implement record patterns in enhanced for
  • fc9d419: 8297928: Update jdk.internal.javac.PreviewFeature.Feature to reflect JEP 432 and JEP 433
  • b60cce6: 8297118: Change IncompatibleClassChangeError to MatchException for exhaustive switch statements and switch expressions
  • cd77609: 8294278: ForkJoinPool.getAndAddPoolIds should use Unsafe.staticFieldBase
  • eea1a8a: 8297427: Avoid keeping class loaders alive when executing ClassLoaderStatsVMOperation
  • 7941147: 8297503: Merge FilteringDCTOC into ContiguousSpaceDCTOC
  • ... and 258 more: https://git.openjdk.org/jdk/compare/499406c764ba0ce57079b1f612297be5b148e5bb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@TobiHartmann @MDBijman Pushed as commit 4899d78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants