8296660: Swing HTML table with omitted closing tags misparsed

[prsadhuk]

This is in continuation with 7133fc9 fix done for JDK-7172359 issue where fix was done to rectify invalid tag causing StackOverflowError but it caused alignment issue if the closing tags are optional, so the fix is modified to check for optional closing tag in which case dont return false for legalElementContext()

JDK-7172359 fix and other CI regression tests are fine.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296660: Swing HTML table with omitted closing tags misparsed

Reviewers

• Phil Race (@prrace - Reviewer) ⚠️ Review applies to d92e446b
• Jayathirth D V (@jayathirthrao - Reviewer) ⚠️ Review applies to d92e446b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11355/head:pull/11355
$ git checkout pull/11355

Update a local copy of the PR:
$ git checkout pull/11355
$ git pull https://git.openjdk.org/jdk pull/11355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11355

View PR using the GUI difftool:
$ git pr show -t 11355

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11355.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d075a9ba)
• 00: Full (d92e446b)

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296660: Swing HTML table with omitted closing tags misparsed

Reviewed-by: prr, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 6f06f44: 8297242: Use-after-free during library unloading on Linux
• 4e8e853: 6788481: CellEditorListener.editingCanceled is never called
• 692bedb: 8297106: Remove the -Xcheck:jni local reference capacity checking
• 05128c2: 8286185: The Java manpage can be more platform inclusive
• d450314: 8297276: Remove thread text from Subject.current
• cdf9ed0: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64
• 105d9d7: 8295351: java/lang/Float/Binary16Conversion.java fails with "Unexpected result of converting"
• a80552e: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools
• a249a52: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19
• 405b188: 8297570: jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with -XX:-UseTLAB
• ... and 54 more: https://git.openjdk.org/jdk/compare/b4bd287f736b6b5dcfe1b183cae9b11eb6f22686...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jayathirthrao]

Tested and it works properly with fix.
Also if we can set some size for JFrame in which HTML table is shown would be better.
Without fix when i ran the test, the window was very small and i had to expand it to actually see mangled HTML content.

Or we can add more detail in instruction to expand the frame to see full HTML table in case where issue i seen.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit c612512.
Since your change was applied there have been 120 commits pushed to the master branch:

• 56048f9: 8297852: Backout 8252584 for the time being
• f49acd5: 8297697: RISC-V: Add support for SATP mode detection
• 3b513a4: 8297802: display of @SPEC tags should mimic that of @see tags
• 4485d4e: 8297728: Cache invocation type rather than invoker in NamedFunction
• e9d501e: 8297519: Improve expressions and modernise code in PKCS
• 1722f9c: 8290231: java/foreign/malloc/TestMixedMallocFree.java crashed in JDK19 ATR run
• 1a2ff58: 8297736: test/jdk/java/foreign/TestMatrix.java is broken
• 6bac332: 8297853: windows-x86 test build broken
• 53dd214: 8297742: Combine vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount tests
• 1323e98: 8297170: misc JCK tests fail with "FATAL ERROR in native method: JDWP Can't disable vthread end events, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"
• ... and 110 more: https://git.openjdk.org/jdk/compare/b4bd287f736b6b5dcfe1b183cae9b11eb6f22686...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit c612512.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.