-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297644: RISC-V: Compilation error when shenandoah is disabled #11370
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Also verified by doing a native fastdebug build with --disable-jvm-feature-shenandoahgc. Thanks.
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/integrate |
Going to push as commit 4d730f5.
Your commit was automatically rebased without conflicts. |
If configuring with
--disable-jvm-feature-shenandoahgc
, the risc-v port fails to build.It seems that the code is really dependent on two header files, that is not declared, and probably has "leaked in" somewhere, but only if shenandoah is enabled. I have tried to resolve it to the best of my knowledge, but if you're not happy with the solution, by all means suggest a better way or take over this bug.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11370/head:pull/11370
$ git checkout pull/11370
Update a local copy of the PR:
$ git checkout pull/11370
$ git pull https://git.openjdk.org/jdk pull/11370/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11370
View PR using the GUI difftool:
$ git pr show -t 11370
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11370.diff