Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297644: RISC-V: Compilation error when shenandoah is disabled #11370

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Nov 25, 2022

If configuring with --disable-jvm-feature-shenandoahgc, the risc-v port fails to build.

It seems that the code is really dependent on two header files, that is not declared, and probably has "leaked in" somewhere, but only if shenandoah is enabled. I have tried to resolve it to the best of my knowledge, but if you're not happy with the solution, by all means suggest a better way or take over this bug.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297644: RISC-V: Compilation error when shenandoah is disabled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11370/head:pull/11370
$ git checkout pull/11370

Update a local copy of the PR:
$ git checkout pull/11370
$ git pull https://git.openjdk.org/jdk pull/11370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11370

View PR using the GUI difftool:
$ git pr show -t 11370

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11370.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2022

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@magicus magicus changed the title 8297644: [riscv] Compilation error when shenandoah is disabled 8297644: RISC-V: Compilation error when shenandoah is disabled Nov 25, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 25, 2022
@openjdk
Copy link

openjdk bot commented Nov 25, 2022

@magicus The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 25, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2022

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also verified by doing a native fastdebug build with --disable-jvm-feature-shenandoahgc. Thanks.

@openjdk
Copy link

openjdk bot commented Nov 26, 2022

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297644: RISC-V: Compilation error when shenandoah is disabled

Reviewed-by: fyang, yadongwang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 2f83b5c: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
  • 50f9043: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread
  • 99d3840: 8297359: RISC-V: improve performance of floating Max Min intrinsics
  • 6c05771: 8295447: NullPointerException with invalid pattern matching construct in constructor call
  • 76a24c3: 8297145: Add a @sealedGraph tag to ConstantDesc
  • 099b42f: 8297148: Add a @sealedGraph tag to CallSite
  • 85ddd8f: 8295253: Remove kludge from v1_0/PerfDataBuffer.java
  • 952e100: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
  • 08e6a82: 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run
  • 4f65570: 8294583: JShell: NPE in switch with non existing record pattern
  • ... and 14 more: https://git.openjdk.org/jdk/compare/8b7397064b5b492b03bc8363f6ba74c70ce7d4a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 26, 2022
Copy link
Contributor

@yadongw yadongw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@magicus
Copy link
Member Author

magicus commented Nov 30, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

Going to push as commit 4d730f5.
Since your change was applied there have been 81 commits pushed to the master branch:

  • 27b339d: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check
  • 3f8882b: 8297693: Fix typos in src/hotspot and test/hotspot files
  • b52611b: 8295401: Error recovery in module-info.java could be improved
  • 9e80cf9: 8296390: Incremental build failed with a NPE
  • b3501fd: 8297600: Check current thread in selected JRT_LEAF methods
  • f05bfb1: 8297515: serialVersionUID fields are not annotated with @serial
  • 22f5d01: 8252584: HotSpot Style Guide should permit alignas
  • 8ffed34: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit
  • abe532a: 8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: bad address
  • 5dcaf6c: 8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection
  • ... and 71 more: https://git.openjdk.org/jdk/compare/8b7397064b5b492b03bc8363f6ba74c70ce7d4a0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2022
@openjdk openjdk bot closed this Nov 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@magicus Pushed as commit 4d730f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the riscv-shenandoah branch December 1, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants