Skip to content

Conversation

@turbanoff
Copy link
Member

@turbanoff turbanoff commented Nov 27, 2022

Field javax.imageio.spi.IIORegistry#initialCategories is modified only in static {} block, which makes it effectively final. Instead of legacy synchronized Vector we can use non-threadsafe ArrayList here.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11379/head:pull/11379
$ git checkout pull/11379

Update a local copy of the PR:
$ git checkout pull/11379
$ git pull https://git.openjdk.org/jdk pull/11379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11379

View PR using the GUI difftool:
$ git pr show -t 11379

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11379.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 27, 2022
@turbanoff turbanoff changed the title [PATCH] Unnecessary Vector usage in javax.imageio.spi.IIORegistry 8297750: Unnecessary Vector usage in IIORegistry Nov 29, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297750: Unnecessary Vector usage in IIORegistry

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • abe532a: 8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: bad address
  • 5dcaf6c: 8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection
  • c7a679f: 8297290: Use int indices to reference CDS archived primitive mirrors
  • 37f613b: 8297676: DataBuffer.TYPE_SHORT/TYPE_FLOAT/TYPE_DOUBLE are not placeholders
  • 87f00f4: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters
  • 9ced2ea: 8297311: Improve exception message thrown by java.net.HostPortrange::toLowerCase(String s)
  • defe060: 8296905: Replace the native LCMS#getProfileID() method with the accessor
  • e10778a: 8297695: Fix typos in test/langtools files
  • 0ce1827: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
  • e2d71c0: 8297481: Create a regression test for JDK-4424517
  • ... and 39 more: https://git.openjdk.org/jdk/compare/2f83b5c487f112c175d081ca5882f5032518937a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2022
@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit fa0c599.
Since your change was applied there have been 79 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@turbanoff Pushed as commit fa0c599.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants