-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8297750: Unnecessary Vector usage in IIORegistry #11379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297750: Unnecessary Vector usage in IIORegistry #11379
Conversation
|
👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into |
|
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
src/java.desktop/share/classes/javax/imageio/spi/IIORegistry.java
Outdated
Show resolved
Hide resolved
Apply suggestion from schlosna
|
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit fa0c599.
Your commit was automatically rebased without conflicts. |
|
@turbanoff Pushed as commit fa0c599. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Field
javax.imageio.spi.IIORegistry#initialCategoriesis modified only instatic {}block, which makes it effectively final. Instead of legacy synchronizedVectorwe can use non-threadsafeArrayListhere.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11379/head:pull/11379$ git checkout pull/11379Update a local copy of the PR:
$ git checkout pull/11379$ git pull https://git.openjdk.org/jdk pull/11379/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11379View PR using the GUI difftool:
$ git pr show -t 11379Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11379.diff