Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297733: Refactor Cast binding to enum #11397

Closed
wants to merge 1 commit into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Nov 28, 2022

Refactor the cast binding to an enum, which clearly enumerates all supported conversions.

This also fixes a bug where java/foreign/normalize/TestNormalize was failing when running in interpreted mode (-Djdk.internal.foreign.DowncallLinker.USE_SPEC=false), for conversions from int to byte because the explicitCast method handle that was used only considers the least significant bit, while we want to look at all of the least significant byte.

As mentioned in the JBS issue, doing this will also make it easier going forward to support multiple conversions with the same from and to types, but requiring different semantics.

Testing: jdk_foreign test suite.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11397/head:pull/11397
$ git checkout pull/11397

Update a local copy of the PR:
$ git checkout pull/11397
$ git pull https://git.openjdk.org/jdk pull/11397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11397

View PR using the GUI difftool:
$ git pr show -t 11397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11397.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2022

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into pr/11019 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 28, 2022
@JornVernee JornVernee marked this pull request as ready for review November 29, 2022 13:47
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2022

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JornVernee JornVernee changed the base branch from pr/11019 to master December 5, 2022 14:49
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@JornVernee Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297733: Refactor Cast binding to enum

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2022
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

Going to push as commit a38c63d.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 19d8498: 8297495: j.u.concurrent updates for JDK 20
  • 3288459: 8297606: [AIX] Broken build after JDK-8295475

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2022
@openjdk openjdk bot closed this Dec 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@JornVernee Pushed as commit a38c63d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JornVernee JornVernee deleted the RefactorCast branch December 5, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants