8252584: HotSpot Style Guide should permit alignas

[TheShermanTanker]

Add alignas to the permitted features set with some restrictions. (Thanks @kimbarrett for the help)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8252584: HotSpot Style Guide should permit alignas

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to cec044b4

Contributors

• Kim Barrett <kbarrett@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11404/head:pull/11404
$ git checkout pull/11404

Update a local copy of the PR:
$ git checkout pull/11404
$ git pull https://git.openjdk.org/jdk pull/11404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11404

View PR using the GUI difftool:
$ git pr show -t 11404

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11404.diff

[bridgekeeper]

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheShermanTanker The following labels will be automatically applied to this pull request:

• build
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (43683f1b)
• 00: Full (cec044b4)

[kimbarrett]

I think this is okay (not surprisingly). Please add me as a contributor.

[openjdk]

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252584: HotSpot Style Guide should permit alignas

Co-authored-by: Kim Barrett <kbarrett@openjdk.org>
Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheShermanTanker]

/contributor kimbarrett

[openjdk]

@TheShermanTanker Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[TheShermanTanker]

/contributor add @kimbarrett

[TheShermanTanker]

/integrate

[openjdk]

@TheShermanTanker
Contributor Kim Barrett <kbarrett@openjdk.org> successfully added.

[openjdk]

@TheShermanTanker
Your change (at version cec044b) is now ready to be sponsored by a Committer.

[TheShermanTanker]

/integrate

[openjdk]

Going to push as commit 22f5d01.
Since your change was applied there has been 1 commit pushed to the master branch:

• 8ffed34: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker Pushed as commit 22f5d01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[kimbarrett]

This change should not have been integrated yet. Changes to the Style Guide have an approval process that is described in that document, including a 2 week voting period and final approval by the HotSpot lead.

[TheShermanTanker]

Oops, I did not realize that

Temporarily back this out for now? I can (hopefully) do that rather quickly

[TheShermanTanker]

I've created an "emergency" revert at #11433, sorry for the mistake