Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296710: Update to use jtreg 7.1 #11416

wants to merge 1 commit into from


Copy link

@sormuras sormuras commented Nov 29, 2022

Please review the change to update to using jtreg 7.1.

The primary change is to the jib-profiles.js file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various TEST.ROOT files.

This pull request was created by copying the following and using 7.1 at appropriate places:


  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue




Using git

Checkout this PR locally:
$ git fetch pull/11416/head:pull/11416
$ git checkout pull/11416

Update a local copy of the PR:
$ git checkout pull/11416
$ git pull pull/11416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11416

View PR using the GUI difftool:
$ git pr show -t 11416

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Nov 29, 2022

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2022
Copy link

openjdk bot commented Nov 29, 2022

@sormuras The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build hotspot core-libs compiler labels Nov 29, 2022
Copy link

mlbridge bot commented Nov 29, 2022


Copy link

Can you confirm that you've run all the tests with the change? Sometimes these updates need changes to a small number of tests.

Copy link

openjdk bot commented Nov 29, 2022

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8296710: Update to use jtreg 7.1

Reviewed-by: erikj, alanb, jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • 3b513a4: 8297802: display of @SPEC tags should mimic that of @see tags
  • 4485d4e: 8297728: Cache invocation type rather than invoker in NamedFunction
  • e9d501e: 8297519: Improve expressions and modernise code in PKCS
  • 1722f9c: 8290231: java/foreign/malloc/ crashed in JDK19 ATR run
  • 1a2ff58: 8297736: test/jdk/java/foreign/ is broken
  • 6bac332: 8297853: windows-x86 test build broken
  • 53dd214: 8297742: Combine vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount tests
  • 1323e98: 8297170: misc JCK tests fail with "FATAL ERROR in native method: JDWP Can't disable vthread end events, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"
  • c685569: 8297731: Remove redundant check in MutableBigInteger.divide
  • dcf431d: 8287400: Make BitMap range parameter names consistent
  • ... and 33 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2022
Copy link

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christian has confirmed on the testing so I think this is good.

Copy link
Member Author

sormuras commented Dec 1, 2022


Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit c70d1e1.
Since your change was applied there have been 62 commits pushed to the master branch:

  • 4899d78: 8293294: Remove dead code in Parse::check_interpreter_type
  • 5459b11: 8297033: G1: Improve logging for Remembered Sets
  • c6156f9: 8297561: Redundant index check in String.offsetByCodePoints()
  • eec24aa: 8295350: JFR: Add stop methods for recording streams
  • 9430f3e: 8297934: [BACKOUT] Compiler should only use verified interface types for optimization
  • 2cb64a7: 8294943: Implement record patterns in enhanced for
  • fc9d419: 8297928: Update jdk.internal.javac.PreviewFeature.Feature to reflect JEP 432 and JEP 433
  • b60cce6: 8297118: Change IncompatibleClassChangeError to MatchException for exhaustive switch statements and switch expressions
  • cd77609: 8294278: ForkJoinPool.getAndAddPoolIds should use Unsafe.staticFieldBase
  • eea1a8a: 8297427: Avoid keeping class loaders alive when executing ClassLoaderStatsVMOperation
  • ... and 52 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
Copy link

openjdk bot commented Dec 1, 2022

@sormuras Pushed as commit c70d1e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras mentioned this pull request Dec 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
build compiler core-libs hotspot integrated Pull request has been integrated
4 participants