Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test #11420

Closed
wants to merge 1 commit into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Nov 29, 2022

Please find here a fix that drops the HttpClient TckDiriver test. This test has been useful when developing the HTTP client APIs. However, it has become a burden to run this test, which is now the longest running HttpClient test. This change proposes to drop the test from the non regression test suite.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11420/head:pull/11420
$ git checkout pull/11420

Update a local copy of the PR:
$ git checkout pull/11420
$ git pull https://git.openjdk.org/jdk pull/11420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11420

View PR using the GUI difftool:
$ git pr show -t 11420

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11420.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2022

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8297645 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test Nov 29, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2022
@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Nov 29, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test

Reviewed-by: alanb, jpai, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • f05bfb1: 8297515: serialVersionUID fields are not annotated with @serial
  • 22f5d01: 8252584: HotSpot Style Guide should permit alignas
  • 8ffed34: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit
  • abe532a: 8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: bad address
  • 5dcaf6c: 8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection
  • c7a679f: 8297290: Use int indices to reference CDS archived primitive mirrors
  • 37f613b: 8297676: DataBuffer.TYPE_SHORT/TYPE_FLOAT/TYPE_DOUBLE are not placeholders
  • 87f00f4: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters
  • 9ced2ea: 8297311: Improve exception message thrown by java.net.HostPortrange::toLowerCase(String s)
  • defe060: 8296905: Replace the native LCMS#getProfileID() method with the accessor
  • ... and 12 more: https://git.openjdk.org/jdk/compare/33587ffd35c568c1ef034f064e6f3f06fe9943c3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2022
@dfuch
Copy link
Member Author

dfuch commented Dec 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 2, 2022

Going to push as commit 6d0fbb2.
Since your change was applied there have been 78 commits pushed to the master branch:

  • 687fd71: 8297549: RISC-V: Add support for Vector API vector load const operation
  • d50015a: 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension
  • 9bbcb54: 8297784: Optimize @stable field for Method.isCallerSensitive
  • 11ba759: 8297992: Tests fail after JDK-8297215 due to lack of @enablePreview
  • b035056: 8297455: Use the official ToolProvider API to call javac
  • 257aa15: 8297444: Refactor the javacserver build tool
  • e846b04: 8297875: jar should not compress the manifest directory entry
  • 82031d3: 8297294: compiler/c2/irTests/TestMulNodeIdealization.java failed compilation
  • 337ca10: 8297978: Exclude vmTestbase/nsk/stress/except/except012.java until 8297977 is fixed
  • 770ff5a: 8297215: Update libs tests to use @enablePreview
  • ... and 68 more: https://git.openjdk.org/jdk/compare/33587ffd35c568c1ef034f064e6f3f06fe9943c3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2022
@openjdk openjdk bot closed this Dec 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2022
@openjdk
Copy link

openjdk bot commented Dec 2, 2022

@dfuch Pushed as commit 6d0fbb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants