8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" #11425

alisenchung · 2022-11-29T23:10:56Z

Test was run on mac, windows, linux 50 times and passed after change
Before fix, test fails about once every 50 runs on linux and windows platforms

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"

Reviewers

Prasanta Sadhukhan (@prsadhuk - Reviewer) ⚠️ Review applies to 8f0e0e71
Damon Nguyen (@DamonGuy - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11425/head:pull/11425
$ git checkout pull/11425

Update a local copy of the PR:
$ git checkout pull/11425
$ git pull https://git.openjdk.org/jdk pull/11425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11425

View PR using the GUI difftool:
$ git pr show -t 11425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11425.diff

bridgekeeper · 2022-11-29T23:12:42Z

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-11-29T23:15:57Z

@alisenchung The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-11-29T23:19:32Z

Webrevs

prsadhuk · 2022-11-30T07:57:16Z

test/jdk/java/awt/Mouse/EnterExitEvents/DragWindowTest.java

@@ -55,7 +55,7 @@ public class DragWindowTest {
    public static void main(String[] args) throws Exception {

        Robot robot = new Robot();
-        robot.setAutoDelay(50);
+        robot.setAutoDelay(250);


We normally do not need so much delay for test to work, 100ms being the norm which has sufficed for other tests.
Maybe you need to wait robot.delay after creating and showing the GUI which is not done here.
Also, this test has heavyweight and lightweight mix, for ex. MyDragWindow class uses JPanel but not in EDT which can result in some timing issue you are seeing, either it needs to be in EDT or can it be changed to AWT Panel as done elsewhere in the test?

ALso, please change the wildcards imports while you are at it..

JPanel question is still unanswered/unchanged...

jayathirthrao

This test was de-problemlisted recently under https://bugs.openjdk.org/browse/JDK-8023562 after running test 100 times in CI. And now with increased auto delay we are trying de-problemlist it again.

With increased auto delay test is passing in our CI on all platforms when ran for 100 times, but we need to refine this test as mentioned by @prsadhuk to add needed delay at appropriate places and remove mixture of lightweight & heavyweight parts.

jayathirthrao · 2022-11-30T07:10:12Z

test/jdk/java/awt/Mouse/EnterExitEvents/DragWindowTest.java

@@ -81,6 +81,7 @@ public Point call() throws Exception {
        robot.waitForIdle();

        if (dragWindowMouseEnteredCount != 1) {
+//            System.out.println("dragWindowMouseEnteredCount " + dragWindowMouseEnteredCount);


We should remove this line or uncomment it(if needed as debug info for future failures)

… gui

DamonGuy · 2022-12-03T05:25:43Z

test/jdk/java/awt/Mouse/EnterExitEvents/DragWindowTest.java

+        robot.delay(250);
        robot.waitForIdle();


Not positive if it matters, but from what I've seen the delay usually comes after waitForIdle.

But I also ran the test and it seems to be OK.

honkar-jdk · 2022-12-05T20:40:00Z

@alisenchung Was this an intermittent issue? If so it is better to run the entire test folder multiple times to catch any intermittent issue.

alisenchung · 2022-12-06T22:09:04Z

After pulling newest changes test is failing again... looking into issue

prsadhuk

I guess it's better to use setLocationRelativeTo() to position the frame to middle of screen too to make it more stable..

openjdk · 2022-12-13T16:24:15Z

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"

Reviewed-by: psadhukhan, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 150 new commits pushed to the master branch:

8ff2928: 8297639: Remove preventive GCs in G1
7241e35: 8298692: Fix typos in test/jdk/com/sun/jdi files
736fcd4: 8296318: use-def assert: special case undetected loops nested in infinite loops
c05dbac: 8193547: Regression automated test '/open/test/jdk/java/awt/Toolkit/DesktopProperties/rfe4758438.java' fails
0dce5b8: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
ed8a212: 8298376: ZGC: thaws stackChunk with stale oops
2e801e1: 8298475: Remove JVM_ACC_PROMOTED_FLAGS
9ee5037: 8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount
ceca4fc: 8298264: Merge OffsetTableContigSpace into TenuredSpace
d32d6c0: 8297791: update _max_classes in node type system
... and 140 more: https://git.openjdk.org/jdk/compare/7d20a60a983e459ea1c4e843fbde70fb796c6249...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

alisenchung · 2022-12-14T22:07:57Z

/integrate

openjdk · 2022-12-14T22:10:17Z

Going to push as commit 0ed6d0b.
Since your change was applied there have been 162 commits pushed to the master branch:

a130c8a: Merge
581f9f2: 8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax
0eeaf6b: 8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4
2791701: 8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."
0bbc418: 8294902: Undefined Behavior in C2 regalloc with null references
9bcdfc4: 8298425: System.console().readLine() hangs in jshell
27d4971: 8298520: C2: assert(found_opaque == res) failed: wrong pattern
51f0a1c: 8298527: Cygwin's uname -m returns different string than before
61ab16f: 8298700: Typo in DocTree comment
c6f22b4: 8297305: Clarify that javax.lang.model.util.Elements.overrides is irreflexive
... and 152 more: https://git.openjdk.org/jdk/compare/7d20a60a983e459ea1c4e843fbde70fb796c6249...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-12-14T22:10:36Z

@alisenchung Pushed as commit 0ed6d0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

dholmes-ora · 2022-12-15T06:44:38Z

@alisenchung this test continues to fail in our CI in tier4. I will file a new bug.

changed robot autodelay to 250

ff6713c

openjdk bot added the rfr Pull request is ready for review label Nov 29, 2022

openjdk bot added the client client-libs-dev@openjdk.org label Nov 29, 2022

prsadhuk reviewed Nov 30, 2022

View reviewed changes

jayathirthrao reviewed Nov 30, 2022

View reviewed changes

fixed imports, changed robot autodelay and added delay after creating…

0e69811

… gui

DamonGuy reviewed Dec 3, 2022

View reviewed changes

Merge branch 'master' of https://github.com/openjdk/jdk into 8297296

8f0e0e7

prsadhuk approved these changes Dec 13, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 13, 2022

setLocationRelativeTo set to null

fb846a7

DamonGuy approved these changes Dec 14, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Dec 14, 2022

openjdk bot closed this Dec 14, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" #11425

8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" #11425

alisenchung commented Nov 29, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 29, 2022

openjdk bot commented Nov 29, 2022

mlbridge bot commented Nov 29, 2022 •

edited

Loading

prsadhuk Nov 30, 2022 •

edited

Loading

prsadhuk Dec 5, 2022

jayathirthrao left a comment

jayathirthrao Nov 30, 2022

DamonGuy Dec 3, 2022

honkar-jdk commented Dec 5, 2022

alisenchung commented Dec 6, 2022

prsadhuk left a comment

openjdk bot commented Dec 13, 2022 •

edited

Loading

alisenchung commented Dec 14, 2022

openjdk bot commented Dec 14, 2022

openjdk bot commented Dec 14, 2022

dholmes-ora commented Dec 15, 2022

8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" #11425

8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" #11425

Conversation

alisenchung commented Nov 29, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 29, 2022

openjdk bot commented Nov 29, 2022

mlbridge bot commented Nov 29, 2022 • edited Loading

Webrevs

prsadhuk Nov 30, 2022 • edited Loading

Choose a reason for hiding this comment

prsadhuk Dec 5, 2022

Choose a reason for hiding this comment

jayathirthrao left a comment

Choose a reason for hiding this comment

jayathirthrao Nov 30, 2022

Choose a reason for hiding this comment

DamonGuy Dec 3, 2022

Choose a reason for hiding this comment

honkar-jdk commented Dec 5, 2022

alisenchung commented Dec 6, 2022

prsadhuk left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 13, 2022 • edited Loading

alisenchung commented Dec 14, 2022

openjdk bot commented Dec 14, 2022

openjdk bot commented Dec 14, 2022

dholmes-ora commented Dec 15, 2022

alisenchung commented Nov 29, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 29, 2022 •

edited

Loading

prsadhuk Nov 30, 2022 •

edited

Loading

openjdk bot commented Dec 13, 2022 •

edited

Loading