-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8297851: Add devkit for RISC-V #11432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
Webrevs
|
@magicus This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Bot, gimme some slack. |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
It turned out we have bugs when cross-compiling riscv, so my attempts at showing that this works in the Oracle CI system has been unsuccessful so far. But now I have a local fix for JDK-8300550 , and it seems promising. |
The solution worked fine, and will be fixed with JDK-8300550. /integrate |
Going to push as commit c205cae.
Your commit was automatically rebased without conflicts. |
We should add devkit support for linux/riscv64.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11432/head:pull/11432
$ git checkout pull/11432
Update a local copy of the PR:
$ git checkout pull/11432
$ git pull https://git.openjdk.org/jdk pull/11432/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11432
View PR using the GUI difftool:
$ git pr show -t 11432
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11432.diff