Skip to content

8297851: Add devkit for RISC-V #11432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

magicus
Copy link
Member

@magicus magicus commented Nov 30, 2022

We should add devkit support for linux/riscv64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11432/head:pull/11432
$ git checkout pull/11432

Update a local copy of the PR:
$ git checkout pull/11432
$ git pull https://git.openjdk.org/jdk pull/11432/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11432

View PR using the GUI difftool:
$ git pr show -t 11432

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11432.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2022

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 30, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2023

@magicus This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@magicus
Copy link
Member Author

magicus commented Jan 16, 2023

Bot, gimme some slack.

@openjdk
Copy link

openjdk bot commented Jan 18, 2023

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297851: Add devkit for RISC-V

Reviewed-by: fyang, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • c3242ee: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
  • b3684f4: 8153837: AArch64: Handle special cases for MaxINode & MinINode
  • 754f6e6: 8300237: Minor improvements in MethodHandles
  • 85d8bac: 8300166: Unused array allocation in ProcessPath.doProcessPath
  • c464ef1: 8292741: Convert JvmtiTagMapTable to ResourceHashtable
  • 1aded82: 8300488: Incorrect usage of CATCH_BAD_ALLOC as a macro call
  • bd5ca95: 8300222: Replace NULL with nullptr in share/logging
  • 15a9186: 8300169: Build failure with clang-15
  • d918042: 8300267: Remove duplicated setter/getter for do_not_unlock
  • 7c8b99e: 8300117: Replace use of JNI_COMMIT mode with mode 0
  • ... and 39 more: https://git.openjdk.org/jdk/compare/a2f67660f088559ce49f73da7401801fb826028b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 18, 2023
@magicus
Copy link
Member Author

magicus commented Jan 18, 2023

It turned out we have bugs when cross-compiling riscv, so my attempts at showing that this works in the Oracle CI system has been unsuccessful so far. But now I have a local fix for JDK-8300550 , and it seems promising.

@magicus
Copy link
Member Author

magicus commented Jan 18, 2023

The solution worked fine, and will be fixed with JDK-8300550.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 18, 2023

Going to push as commit c205cae.
Since your change was applied there have been 49 commits pushed to the master branch:

  • c3242ee: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
  • b3684f4: 8153837: AArch64: Handle special cases for MaxINode & MinINode
  • 754f6e6: 8300237: Minor improvements in MethodHandles
  • 85d8bac: 8300166: Unused array allocation in ProcessPath.doProcessPath
  • c464ef1: 8292741: Convert JvmtiTagMapTable to ResourceHashtable
  • 1aded82: 8300488: Incorrect usage of CATCH_BAD_ALLOC as a macro call
  • bd5ca95: 8300222: Replace NULL with nullptr in share/logging
  • 15a9186: 8300169: Build failure with clang-15
  • d918042: 8300267: Remove duplicated setter/getter for do_not_unlock
  • 7c8b99e: 8300117: Replace use of JNI_COMMIT mode with mode 0
  • ... and 39 more: https://git.openjdk.org/jdk/compare/a2f67660f088559ce49f73da7401801fb826028b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 18, 2023
@openjdk openjdk bot closed this Jan 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2023
@openjdk
Copy link

openjdk bot commented Jan 18, 2023

@magicus Pushed as commit c205cae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the riscv-devkit branch January 29, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants