8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero

[coleenp]

The code for RedefineVerifyMark in redefinition replaces the OopHandle mirror so that the verification has the right mirror, but it really should just copy it. Replacing an OopHandle in the ClassLoaderData didn't set the has_modified_oops flag so GC wasn't noticing that this handle is old.

Tested with tier1-4 and tier6 in progress (linux-x64 and windows-x64 done).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to 2f8d5517
• Erik Österlund (@fisk - Reviewer) ⚠️ Review applies to 2f8d5517
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11444/head:pull/11444
$ git checkout pull/11444

Update a local copy of the PR:
$ git checkout pull/11444
$ git pull https://git.openjdk.org/jdk pull/11444/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11444

View PR using the GUI difftool:
$ git pr show -t 11444

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11444.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (483da5e5)
• 00: Full (2f8d5517)

[sspitsyn]

Coleen,
This looks good.
Wow, it is great you've found the root cause!
It was not easy for sure.
Thanks,
Serguei

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero

Reviewed-by: sspitsyn, eosterlund, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 229 new commits pushed to the master branch:

• 6065696: 8297982: Exclude vmTestbase/nsk/monitoring/stress/lowmem/ with ZGC until 8297979 is fixed
• 415cfd2: 8297285: Shenandoah pacing causes assertion failure during VM initialization
• df07255: 8297984: Turn on warnings as errors for javadoc
• 227364d: 8297953: Fix several C2 IR matching tests for RISC-V
• 1370228: 8297941: Add override modifier in space.hpp
• 319faa5: 8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM
• b73363f: 8297686: JFR: Improve documentation of EventStream::onMetadata(Consumer)
• 1376f33: 8297911: Memory leak in JfrUpcalls::on_retransform
• 5c0ff26: 8291444: GHA builds/tests won't run manually if disabled from automatic running
• 6d0fbb2: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
• ... and 219 more: https://git.openjdk.org/jdk/compare/c4b6920a409fdbacfc0c17de39af5f55420a45b5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Serguei!

[fisk]

Looks good.

[kimbarrett]

Looks good.

[coleenp]

Thanks for reviewing Serguei, Erik. Kim, thank you for the cleaner implementation with swap and for reviewing.

[coleenp]

/integrate

[openjdk]

Going to push as commit fb6fd03.
Since your change was applied there have been 230 commits pushed to the master branch:

• 1b92465: 8297608: JFR: Incorrect duration after chunk rotation
• 6065696: 8297982: Exclude vmTestbase/nsk/monitoring/stress/lowmem/ with ZGC until 8297979 is fixed
• 415cfd2: 8297285: Shenandoah pacing causes assertion failure during VM initialization
• df07255: 8297984: Turn on warnings as errors for javadoc
• 227364d: 8297953: Fix several C2 IR matching tests for RISC-V
• 1370228: 8297941: Add override modifier in space.hpp
• 319faa5: 8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM
• b73363f: 8297686: JFR: Improve documentation of EventStream::onMetadata(Consumer)
• 1376f33: 8297911: Memory leak in JfrUpcalls::on_retransform
• 5c0ff26: 8291444: GHA builds/tests won't run manually if disabled from automatic running
• ... and 220 more: https://git.openjdk.org/jdk/compare/c4b6920a409fdbacfc0c17de39af5f55420a45b5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit fb6fd03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.