Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8297911: Memory leak in JfrUpcalls::on_retransform #11445

Closed

Conversation

jcking
Copy link
Contributor

@jcking jcking commented Dec 1, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297911: Memory leak in JfrUpcalls::on_retransform

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11445/head:pull/11445
$ git checkout pull/11445

Update a local copy of the PR:
$ git checkout pull/11445
$ git pull https://git.openjdk.org/jdk pull/11445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11445

View PR using the GUI difftool:
$ git pr show -t 11445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11445.diff

Signed-off-by: Justin King <jcking@google.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2022

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@jcking The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-jfr hotspot-jfr-dev@openjdk.org rfr Pull request is ready for review labels Dec 1, 2022
@jcking
Copy link
Contributor Author

jcking commented Dec 1, 2022

Waiting on another test run to verify I got the memory leak. I think the approach is correct, but I need an adult to confirm.

@mlbridge
Copy link

mlbridge bot commented Dec 1, 2022

Webrevs

@jcking
Copy link
Contributor Author

jcking commented Dec 1, 2022

Waiting on another test run to verify I got the memory leak.

Test run looks good, no more leak.

@mgronlun
Copy link

mgronlun commented Dec 1, 2022

Hi Justin, thanks for bringing this to our attention.
I wrote a note in the JIRA issue and am currently investigating.

Copy link

@mgronlun mgronlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this.

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297911: Memory leak in JfrUpcalls::on_retransform

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • b035056: 8297455: Use the official ToolProvider API to call javac
  • 257aa15: 8297444: Refactor the javacserver build tool
  • e846b04: 8297875: jar should not compress the manifest directory entry
  • 82031d3: 8297294: compiler/c2/irTests/TestMulNodeIdealization.java failed compilation
  • 337ca10: 8297978: Exclude vmTestbase/nsk/stress/except/except012.java until 8297977 is fixed
  • 770ff5a: 8297215: Update libs tests to use @enablePreview
  • c69aa42: 8297968: Crash in PrintOptoAssembly
  • 5a5ced3: 8297830: aarch64: Make Address a discriminated union internally
  • 391599b: 8297313: Refactor APIs for calculating address of CDS archive heap regions
  • 0962957: 8297449: Update JInternalFrame Metal Border code
  • ... and 19 more: https://git.openjdk.org/jdk/compare/56048f9718d1104227795a23c02fa144543c07d0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mgronlun) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2022
@jcking
Copy link
Contributor Author

jcking commented Dec 2, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 2, 2022
@openjdk
Copy link

openjdk bot commented Dec 2, 2022

@jcking
Your change (at version 54d9dfd) is now ready to be sponsored by a Committer.

@mgronlun
Copy link

mgronlun commented Dec 2, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 2, 2022

Going to push as commit 1376f33.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 5c0ff26: 8291444: GHA builds/tests won't run manually if disabled from automatic running
  • 6d0fbb2: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
  • 687fd71: 8297549: RISC-V: Add support for Vector API vector load const operation
  • d50015a: 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension
  • 9bbcb54: 8297784: Optimize @stable field for Method.isCallerSensitive
  • 11ba759: 8297992: Tests fail after JDK-8297215 due to lack of @enablePreview
  • b035056: 8297455: Use the official ToolProvider API to call javac
  • 257aa15: 8297444: Refactor the javacserver build tool
  • e846b04: 8297875: jar should not compress the manifest directory entry
  • 82031d3: 8297294: compiler/c2/irTests/TestMulNodeIdealization.java failed compilation
  • ... and 25 more: https://git.openjdk.org/jdk/compare/56048f9718d1104227795a23c02fa144543c07d0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2022
@openjdk openjdk bot closed this Dec 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 2, 2022
@openjdk
Copy link

openjdk bot commented Dec 2, 2022

@mgronlun @jcking Pushed as commit 1376f33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants