Skip to content

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Dec 1, 2022

Test seems to fail intermittently in ubuntu OCI VM although it passes locally and in other physical system.
Although I am not able to reproduce it on VM, tried some robot safeguards used in other tests.
Modified tests passed several iterations in couple of OCI VM hosts and other physical systems , link of whose jobs are in JBS
so we can deproblemlist it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11455/head:pull/11455
$ git checkout pull/11455

Update a local copy of the PR:
$ git checkout pull/11455
$ git pull https://git.openjdk.org/jdk pull/11455/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11455

View PR using the GUI difftool:
$ git pr show -t 11455

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11455.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 1, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2022

Webrevs

Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@mrserb
Copy link
Member

mrserb commented Dec 2, 2022

The image from the failure handler attached to the issue shows that the screen was locked during test execution, could it be a root cause?

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Dec 2, 2022

The image from the failure handler attached to the issue shows that the screen was locked during test execution, could it be a root cause?

Lock screen was a known issue with how this lot of OCI VMs are churned but strange thing was it did not affect any other test. We could just deproblemlist it citing this but thought of adding more safeguards and screenshot at actual time of failure to verify, if it fails again for some reason..

@openjdk
Copy link

openjdk bot commented Dec 2, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM

Reviewed-by: tr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 149 new commits pushed to the master branch:

  • b035056: 8297455: Use the official ToolProvider API to call javac
  • 257aa15: 8297444: Refactor the javacserver build tool
  • e846b04: 8297875: jar should not compress the manifest directory entry
  • 82031d3: 8297294: compiler/c2/irTests/TestMulNodeIdealization.java failed compilation
  • 337ca10: 8297978: Exclude vmTestbase/nsk/stress/except/except012.java until 8297977 is fixed
  • 770ff5a: 8297215: Update libs tests to use @enablePreview
  • c69aa42: 8297968: Crash in PrintOptoAssembly
  • 5a5ced3: 8297830: aarch64: Make Address a discriminated union internally
  • 391599b: 8297313: Refactor APIs for calculating address of CDS archive heap regions
  • 0962957: 8297449: Update JInternalFrame Metal Border code
  • ... and 139 more: https://git.openjdk.org/jdk/compare/b4bd287f736b6b5dcfe1b183cae9b11eb6f22686...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2022
@prsadhuk
Copy link
Contributor Author

prsadhuk commented Dec 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 2, 2022

Going to push as commit 319faa5.
Since your change was applied there have been 157 commits pushed to the master branch:

  • b73363f: 8297686: JFR: Improve documentation of EventStream::onMetadata(Consumer)
  • 1376f33: 8297911: Memory leak in JfrUpcalls::on_retransform
  • 5c0ff26: 8291444: GHA builds/tests won't run manually if disabled from automatic running
  • 6d0fbb2: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
  • 687fd71: 8297549: RISC-V: Add support for Vector API vector load const operation
  • d50015a: 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension
  • 9bbcb54: 8297784: Optimize @stable field for Method.isCallerSensitive
  • 11ba759: 8297992: Tests fail after JDK-8297215 due to lack of @enablePreview
  • b035056: 8297455: Use the official ToolProvider API to call javac
  • 257aa15: 8297444: Refactor the javacserver build tool
  • ... and 147 more: https://git.openjdk.org/jdk/compare/b4bd287f736b6b5dcfe1b183cae9b11eb6f22686...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2022
@openjdk openjdk bot closed this Dec 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2022
@openjdk
Copy link

openjdk bot commented Dec 2, 2022

@prsadhuk Pushed as commit 319faa5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the 8296084 branch December 2, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants