Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297978: Exclude vmTestbase/nsk/stress/except/except012.java until 8297977 is fixed #11466

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Dec 1, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297978: Exclude vmTestbase/nsk/stress/except/except012.java until 8297977 is fixed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11466/head:pull/11466
$ git checkout pull/11466

Update a local copy of the PR:
$ git checkout pull/11466
$ git pull https://git.openjdk.org/jdk pull/11466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11466

View PR using the GUI difftool:
$ git pr show -t 11466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11466.diff

@lmesnik lmesnik changed the title 8297978: 8297978: Exclude vmTestbase/nsk/stress/except/except012.java until 8297977 is fixed Dec 1, 2022
@lmesnik
Copy link
Member Author

lmesnik commented Dec 1, 2022

/cc hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@lmesnik
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2022

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297978: Exclude vmTestbase/nsk/stress/except/except012.java until 8297977 is fixed

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 770ff5a: 8297215: Update libs tests to use @enablePreview
  • c69aa42: 8297968: Crash in PrintOptoAssembly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2022
@lmesnik
Copy link
Member Author

lmesnik commented Dec 1, 2022

/integrate
Thank you, Dan.

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit 337ca10.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 770ff5a: 8297215: Update libs tests to use @enablePreview
  • c69aa42: 8297968: Crash in PrintOptoAssembly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@lmesnik Pushed as commit 337ca10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8297978 branch June 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants