Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298043: jdk/jfr/api/consumer/recordingstream/TestStop.java failed with "Expected outer stream to have 3 events" #11495

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Dec 3, 2022

Could I have a review of a test and product fix.

Testing: 100 * test/jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ 8298043 is used in problem lists: [test/jdk/ProblemList.txt]

Issue

  • JDK-8298043: jdk/jfr/api/consumer/recordingstream/TestStop.java failed with "Expected outer stream to have 3 events"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11495/head:pull/11495
$ git checkout pull/11495

Update a local copy of the PR:
$ git checkout pull/11495
$ git pull https://git.openjdk.org/jdk pull/11495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11495

View PR using the GUI difftool:
$ git pr show -t 11495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11495.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Dec 3, 2022
@egahlin egahlin marked this pull request as ready for review December 3, 2022 04:13
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2022

Webrevs

@egahlin egahlin marked this pull request as draft December 5, 2022 17:15
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 5, 2022
@egahlin egahlin closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org
2 participants