Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter #11498

Closed
wants to merge 1 commit into from

Conversation

rajamah
Copy link
Member

@rajamah rajamah commented Dec 3, 2022

The test is failing because there was no gap between the Textfields.
I fixed it by adding Vertical Struts in between Textfields.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11498/head:pull/11498
$ git checkout pull/11498

Update a local copy of the PR:
$ git checkout pull/11498
$ git pull https://git.openjdk.org/jdk pull/11498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11498

View PR using the GUI difftool:
$ git pr show -t 11498

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11498.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2022

👋 Welcome back rajamah! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2022
@openjdk
Copy link

openjdk bot commented Dec 3, 2022

@rajamah The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 3, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 3, 2022

@rajamah This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter

Reviewed-by: aivanov, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 336d230: 8297958: NMT: Display peak values
  • 0d2a9ee: 8298142: Update internal comment on language features in SourceVersion
  • 203251f: 8297379: Enable the ByteBuffer path of Poly1305 optimizations
  • 1e46832: 8297602: Compiler crash with type annotation and generic record during pattern matching
  • b0e5432: 8297687: new URI(S,S,S,S) throws exception with incorrect index position reported in the error message
  • 2243646: 8298145: Remove ContiguousSpace::capacity
  • 84b927a: 8296024: Usage of DirectBuffer::address should be guarded
  • a9e6c62: 8297186: G1 triggers unnecessary full GCs when heap utilization is low
  • 4458de9: 8297172: Fix some issues of auto-vectorization of Long.bitCount/numberOfTrailingZeros/numberOfLeadingZeros()
  • a613998: 8297689: Fix incorrect result of Short.reverseBytes() call in loops
  • ... and 42 more: https://git.openjdk.org/jdk/compare/c67166f1205c1123497a8895c2952c4d9933645e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @honkar-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 3, 2022
@rajamah
Copy link
Member Author

rajamah commented Dec 5, 2022

The test is failing because there was no gap between the Textfields.
I fixed it by adding Vertical Struts in between Textfields.

@honkar-jdk
Copy link
Contributor

Before the fix the test failed if both, showFrame and saveImages were hardcoded to true. With the fix test works fine.

@rajamah
Copy link
Member Author

rajamah commented Dec 6, 2022

/integrate

@honkar-jdk
Copy link
Contributor

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@rajamah
Your change (at version 133e158) is now ready to be sponsored by a Committer.

@honkar-jdk
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit ea83cb9.
Since your change was applied there have been 52 commits pushed to the master branch:

  • 336d230: 8297958: NMT: Display peak values
  • 0d2a9ee: 8298142: Update internal comment on language features in SourceVersion
  • 203251f: 8297379: Enable the ByteBuffer path of Poly1305 optimizations
  • 1e46832: 8297602: Compiler crash with type annotation and generic record during pattern matching
  • b0e5432: 8297687: new URI(S,S,S,S) throws exception with incorrect index position reported in the error message
  • 2243646: 8298145: Remove ContiguousSpace::capacity
  • 84b927a: 8296024: Usage of DirectBuffer::address should be guarded
  • a9e6c62: 8297186: G1 triggers unnecessary full GCs when heap utilization is low
  • 4458de9: 8297172: Fix some issues of auto-vectorization of Long.bitCount/numberOfTrailingZeros/numberOfLeadingZeros()
  • a613998: 8297689: Fix incorrect result of Short.reverseBytes() call in loops
  • ... and 42 more: https://git.openjdk.org/jdk/compare/c67166f1205c1123497a8895c2952c4d9933645e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@honkar-jdk @rajamah Pushed as commit ea83cb9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@honkar-jdk The command sponsor can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants