Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298057: (fs) Remove PollingWatchService.POLLING_INIT_DELAY #11499

Closed
wants to merge 3 commits into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Dec 4, 2022

PollingWatchService is an implementation of WatchService for platforms that don't have a native implementation. It works by polling the timestamps of files in the registered directories. When a WatchService is initially created, the first poll should be at the polling interval. The changes in JDK-8285956 were intended to reduce the polling interval to 2s but also changed the initial poll to 1s. This PR just restores that part of the change so the first poll after creation will be at the polling interval, which was how it was originally before that change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298057: (fs) Remove PollingWatchService.POLLING_INIT_DELAY

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11499/head:pull/11499
$ git checkout pull/11499

Update a local copy of the PR:
$ git checkout pull/11499
$ git pull https://git.openjdk.org/jdk pull/11499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11499

View PR using the GUI difftool:
$ git pr show -t 11499

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11499.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2022

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@AlanBateman The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Dec 4, 2022
@AlanBateman AlanBateman marked this pull request as ready for review December 5, 2022 16:52
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298057: (fs) Remove PollingWatchService.POLLING_INIT_DELAY

Reviewed-by: bpb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e975418: 8298102: Remove DirtyCardToOopClosure::_last_explicit_min_done
  • 04012c4: 8298111: Cleanups after UseMallocOnly removal

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2022
Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. The copyright year will need an update.

@AlanBateman
Copy link
Contributor Author

The copyright year will need an update.

Thanks, I had missed that this needs to be update. Will do that before integrating.

@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit 923c746.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 0bd04a6: 8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • f5ad515: 8297247: Add GarbageCollectorMXBean for Remark and Cleanup pause time in G1
  • e975418: 8298102: Remove DirtyCardToOopClosure::_last_explicit_min_done
  • 04012c4: 8298111: Cleanups after UseMallocOnly removal

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@AlanBateman Pushed as commit 923c746.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
3 participants