-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8298057: (fs) Remove PollingWatchService.POLLING_INIT_DELAY #11499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. The copyright year will need an update.
Thanks, I had missed that this needs to be update. Will do that before integrating. |
/integrate |
Going to push as commit 923c746.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit 923c746. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
PollingWatchService is an implementation of WatchService for platforms that don't have a native implementation. It works by polling the timestamps of files in the registered directories. When a WatchService is initially created, the first poll should be at the polling interval. The changes in JDK-8285956 were intended to reduce the polling interval to 2s but also changed the initial poll to 1s. This PR just restores that part of the change so the first poll after creation will be at the polling interval, which was how it was originally before that change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11499/head:pull/11499
$ git checkout pull/11499
Update a local copy of the PR:
$ git checkout pull/11499
$ git pull https://git.openjdk.org/jdk pull/11499/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11499
View PR using the GUI difftool:
$ git pr show -t 11499
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11499.diff