Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298067: Persistent test failures after 8296012 #11500

Closed
wants to merge 2 commits into from

Conversation

TheShermanTanker
Copy link
Contributor

@TheShermanTanker TheShermanTanker commented Dec 4, 2022

After JDK-8296012 a langtools test consistently fails on x86 Linux. This is due to said test needing JVMTI and --enable-preview, but for both to be compatible VMContinuations needs to be manually enabled, since it is off by default on certain platforms. HotSpot otherwise rejects the JVMTI request if VMContinuations is not enabled


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11500/head:pull/11500
$ git checkout pull/11500

Update a local copy of the PR:
$ git checkout pull/11500
$ git pull https://git.openjdk.org/jdk pull/11500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11500

View PR using the GUI difftool:
$ git pr show -t 11500

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11500.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2022

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8298067 8298067: Persistent test failures after 8296012 Dec 4, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@TheShermanTanker The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Dec 4, 2022
@TheShermanTanker
Copy link
Contributor Author

/label hotspot

@mlbridge
Copy link

mlbridge bot commented Dec 4, 2022

Webrevs

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@TheShermanTanker
The hotspot label was successfully added.

@AlanBateman
Copy link
Contributor

/label remove hotspot

@AlanBateman
Copy link
Contributor

This is another test that needs @requires vm.continuations, look at test/langtools/jdk/jshell/Test8294583.java for an example.

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@AlanBateman
The hotspot label was successfully removed.

@TheShermanTanker
Copy link
Contributor Author

Alright, will do that asap

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298067: Persistent test failures after 8296012

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 87572d4: 8298068: ProblemList tests failing due to JDK-8297235

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2022
@TheShermanTanker
Copy link
Contributor Author

Thanks Alan for the review, will set to automatically integrate if there are no other objections

@TheShermanTanker
Copy link
Contributor Author

/integrate auto

@openjdk openjdk bot added the auto label Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@TheShermanTanker This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

Going to push as commit a71d91b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 87572d4: 8298068: ProblemList tests failing due to JDK-8297235

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2022
@openjdk openjdk bot closed this Dec 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@openjdk[bot] Pushed as commit a71d91b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker TheShermanTanker deleted the patch-5 branch December 4, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto integrated Pull request has been integrated kulla kulla-dev@openjdk.org
2 participants