Skip to content

8298068: ProblemList tests failing due to JDK-8297235 #11501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 4, 2022

Batch of ProblemListings to reduce the noise in the JDK20 CI:

JDK-8298068 ProblemList tests failing due to JDK-8297235
JDK-8298070 ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64
JDK-8298071 ProblemList tests failing due to JDK-8298059
JDK-8298072 ProblemList compiler/c1/TestPrintC1Statistics.java in Xcomp mode on linux-aarch64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8298068: ProblemList tests failing due to JDK-8297235
  • JDK-8298070: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64
  • JDK-8298071: ProblemList tests failing due to JDK-8298059
  • JDK-8298072: ProblemList compiler/c1/TestPrintC1Statistics.java in Xcomp mode on linux-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11501/head:pull/11501
$ git checkout pull/11501

Update a local copy of the PR:
$ git checkout pull/11501
$ git pull https://git.openjdk.org/jdk pull/11501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11501

View PR using the GUI difftool:
$ git pr show -t 11501

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11501.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8298068
/issue JDK-8298070
/issue JDK-8298071
/issue JDK-8298072

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-compiler
/label add hotspot-gc

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 4, 2022 16:17
@openjdk openjdk bot changed the title Jdk 8298068 8298068: ProblemList tests failing due to JDK-8297235 Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298070: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64.

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298071: ProblemList tests failing due to JDK-8298059.

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298072: ProblemList compiler/c1/TestPrintC1Statistics.java in Xcomp mode on linux-aarch64.

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298068: ProblemList tests failing due to JDK-8297235
8298070: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64
8298071: ProblemList tests failing due to JDK-8298059
8298072: ProblemList compiler/c1/TestPrintC1Statistics.java in Xcomp mode on linux-aarch64

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 0edb5d0: 8297683: Use enhanced-for cycle instead of Enumeration in java.security.jgss
  • c67166f: 8298003: NMT: fatal block printout does not show the correct corruption address
  • 99e2ef4: 8298054: ProblemList jdk/jfr/api/consumer/recordingstream/TestStop.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated hotspot-runtime hotspot-runtime-dev@openjdk.org labels Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 4, 2022

Webrevs

@dcubed-ojdk
Copy link
Member Author

@azvegint - Thanks for the lightning fast review. Especially for a Sunday AM.
You reviewed before the bots were done with all their tweaking...

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

Going to push as commit 87572d4.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 0edb5d0: 8297683: Use enhanced-for cycle instead of Enumeration in java.security.jgss
  • c67166f: 8298003: NMT: fatal block printout does not show the correct corruption address
  • 99e2ef4: 8298054: ProblemList jdk/jfr/api/consumer/recordingstream/TestStop.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2022
@openjdk openjdk bot closed this Dec 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@dcubed-ojdk Pushed as commit 87572d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8298068 branch December 5, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants