8295184: Printing messages with a RecordComponentElement does not include position

[sadayapalam]

Stash away a copy of the record component declaration from the header for use in diagnostics

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295184: Printing messages with a RecordComponentElement does not include position

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer) ⚠️ Review applies to 754966c6

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11511/head:pull/11511
$ git checkout pull/11511

Update a local copy of the PR:
$ git checkout pull/11511
$ git pull https://git.openjdk.org/jdk pull/11511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11511

View PR using the GUI difftool:
$ git pr show -t 11511

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11511.diff

[bridgekeeper]

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sadayapalam The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a35c12b8)
• 01: Full - Incremental (804eb9c3)
• 00: Full (754966c6)

[sadayapalam]

At the moment, Record components as modelled by Javac do not have a backing AST. The record header declaration which according to JLS actually declares the record components, is folded into the private field declarations. When an annotation processor wants to print a message involving a record component, this becomes a blocker.

The present PR solves this problem by building upon what javac already does - for various reasons javac squirrels away the full list of annotations applied to a record component in the field originalAnnos of RecordComponent. Rather than just save away annotations alone, the present fix stashes away the entire AST, so this can be surfaced when required.

[vicente-romero-oracle]

just a minor suggestion, looks good

[vicente-romero-oracle]

I wouldn't let this field public, we would like to at least control who has write access to it. My proposal is to make it private and let clients read it using an accessor

[openjdk]

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295184: Printing messages with a RecordComponentElement does not include position

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• ba2d28e: 8298027: Remove SCCS id's from awt jtreg tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sadayapalam]

/integrate

[openjdk]

Going to push as commit ee9ba74.
Since your change was applied there has been 1 commit pushed to the master branch:

• ba2d28e: 8298027: Remove SCCS id's from awt jtreg tests

Your commit was automatically rebased without conflicts.

[openjdk]

@sadayapalam Pushed as commit ee9ba74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.