Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298102: Remove DirtyCardToOopClosure::_last_explicit_min_done #11512

wants to merge 1 commit into from


Copy link

@albertnetymk albertnetymk commented Dec 5, 2022

Trivial change of removing effectively dead code.


  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue


  • JDK-8298102: Remove DirtyCardToOopClosure::_last_explicit_min_done



Using git

Checkout this PR locally:
$ git fetch pull/11512/head:pull/11512
$ git checkout pull/11512

Update a local copy of the PR:
$ git checkout pull/11512
$ git pull pull/11512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11512

View PR using the GUI difftool:
$ git pr show -t 11512

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Dec 5, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8298102 8298102: Remove DirtyCardToOopClosure::_last_explicit_min_done Dec 5, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2022
Copy link

openjdk bot commented Dec 5, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Dec 5, 2022
Copy link

mlbridge bot commented Dec 5, 2022


Copy link

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial.

Copy link

openjdk bot commented Dec 5, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8298102: Remove DirtyCardToOopClosure::_last_explicit_min_done

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 73baadc: 8295044: Implementation of Foreign Function and Memory API (Second Preview)
  • bd38188: 8297766: Remove UseMallocOnly development option
  • b9eec96: 8281214: Unsafe use of long in VMThread::setup_periodic_safepoint_if_needed
  • e7e0354: 8297767: Assert JNICritical_lock/safepoint-1 and AdapterHandlerLibrary_lock/safepoint-1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2022
Copy link
Member Author

Thanks for the review.


Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit e975418.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 04012c4: 8298111: Cleanups after UseMallocOnly removal
  • ee9ba74: 8295184: Printing messages with a RecordComponentElement does not include position
  • ba2d28e: 8298027: Remove SCCS id's from awt jtreg tests
  • 8d8a28f: 8296489: tools/jpackage/windows/ fails with timeout
  • 884b9ad: 8293453: tools/jpackage/share/ "Failed: Check the number of mismatched pixels [1024] of [1024] is < [0.100000] threshold"
  • 8af6e8a: 8298123: Problem List on macOS
  • da0917a: 8297729: Replace GrowableArray in ComputeMoveOrder with hash table
  • 9827b75: 8298043: jdk/jfr/api/consumer/recordingstream/ failed with "Expected outer stream to have 3 events"
  • 7d20a60: 8297489: Modify as to verify the content change of TextComponent sends TextEvent
  • 601264d: 8273357: SecurityManager deprecation warning from java/awt/regtesthelpers/
  • ... and 9 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2022
@albertnetymk albertnetymk deleted the s1-unused branch December 6, 2022 06:48
Copy link

openjdk bot commented Dec 6, 2022

@albertnetymk Pushed as commit e975418.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-gc integrated Pull request has been integrated
2 participants