Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298108: Add a regression test for JDK-8297684 #11515

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Dec 5, 2022

Please review this test addition as it would have helped discover a regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced and subsequently backported. What's more, it might help discover similar issues going forward. Thoughts?

Testing: Manually produced a build without JDK-8269039. Test fails without the fix, passes after.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11515/head:pull/11515
$ git checkout pull/11515

Update a local copy of the PR:
$ git checkout pull/11515
$ git pull https://git.openjdk.org/jdk pull/11515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11515

View PR using the GUI difftool:
$ git pr show -t 11515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11515.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@jerboaa The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 5, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2022

Webrevs

@seanjmullan
Copy link
Member

A regression test was added as part of the fix for https://bugs.openjdk.org/browse/JDK-8280890. See the commit log for more details: a0f6f24#diff-6de8303e80bab41e34a29b272cff64a68d3b255f0f147ee16ef21680abf7f41a

Since this is a different way of testing the same underlying issue and the problem shows up in more than one way, I agree it is a good idea to add another regression test. However, I would put in the same test directory as 8280890: test/jdk/java/security/SignedJar

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 6, 2022

Since this is a different way of testing the same underlying issue and the problem shows up in more than one way, I agree it is a good idea to add another regression test. However, I would put in the same test directory as 8280890: test/jdk/java/security/SignedJar

Sounds good. I'll do that.

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 6, 2022

Should be ready now, thanks!

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298108: Add a regression test for JDK-8297684

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 186 new commits pushed to the master branch:

  • ea83cb9: 8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter
  • 336d230: 8297958: NMT: Display peak values
  • 0d2a9ee: 8298142: Update internal comment on language features in SourceVersion
  • 203251f: 8297379: Enable the ByteBuffer path of Poly1305 optimizations
  • 1e46832: 8297602: Compiler crash with type annotation and generic record during pattern matching
  • b0e5432: 8297687: new URI(S,S,S,S) throws exception with incorrect index position reported in the error message
  • 2243646: 8298145: Remove ContiguousSpace::capacity
  • 84b927a: 8296024: Usage of DirectBuffer::address should be guarded
  • a9e6c62: 8297186: G1 triggers unnecessary full GCs when heap utilization is low
  • 4458de9: 8297172: Fix some issues of auto-vectorization of Long.bitCount/numberOfTrailingZeros/numberOfLeadingZeros()
  • ... and 176 more: https://git.openjdk.org/jdk/compare/952e10055135613e8ea2b818a4f35842936f5633...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 6, 2022
@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 7, 2022

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2022

Going to push as commit 4da8411.
Since your change was applied there have been 202 commits pushed to the master branch:

  • 80cbfab: 8298169: Remove unused methods in space.hpp
  • 221e1a4: 8286666: JEP 429: Implementation of Scoped Values (Incubator)
  • ccc69af: 8296672: Implementation of Virtual Threads (Second Preview)
  • 5a3439d: 4677581: ColorModel.getComponentSize()-wrong conditions for ArrayIndexOutOfBoundsExceptio
  • 27bbe7b: 8297976: Remove sun.net.ProgressMonitor and related classes
  • 085f96c: 8295258: Add BasicType argument to AccessInternal::decorator_fixup
  • 1c2a093: 8298147: Clang warns about pointless comparisons
  • 8ea369a: 8298171: Missing newline in the example output of -Xlog:help
  • acf96c6: 8290432: C2 compilation fails with assert(node->_last_del == _last) failed: must have deleted the edge just produced
  • ce89673: 8297804: (tz) Update Timezone Data to 2022g
  • ... and 192 more: https://git.openjdk.org/jdk/compare/952e10055135613e8ea2b818a4f35842936f5633...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2022
@openjdk openjdk bot closed this Dec 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@jerboaa Pushed as commit 4da8411.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@seanjmullan
Copy link
Member

The fix has caused a regression on the Windows x64 platform and is affecting tier2 testing. I'll file a bug shortly. Here is a snippet from the log file:

stderr: [Exception in thread "main" java.lang.RuntimeException: Test failed with signed jar and argument java.locale.providers=SPI
at TestSPISigned.doRunTest(TestSPISigned.java:115)
at TestSPISigned.main(TestSPISigned.java:75)
Caused by: java.lang.RuntimeException: Expected calendar from SPI to be in effect: expected 4 to equal 1
at jdk.test.lib.Asserts.fail(Asserts.java:594)
at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
at TestSPISigned.check(TestSPISigned.java:121)
at TestSPISigned.doRunTest(TestSPISigned.java:112)
... 1 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants