Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working #11531

wants to merge 3 commits into from


Copy link

@mrserb mrserb commented Dec 6, 2022

We have two types of properties in Swing, the "basics": were implemented a long time ago. Some of that properties are tested by the bug4314194 test. And other properties implemented as part of the Synth L&F, and based on it - Nimbus/GTK. Attempt to fix the issue reported by bug4314194 added support of two "basic" options to the Nimbus/GTK but at the same time broke the Synth/Nimbus properties. It is unclear what is the root cause and how these properties should work together(should they? I assume each "basic"/"synth" should support its own) I suggest to revert the changes in 20 to prevent the regression and rethink the solution later.

In short, this is a request to revert the next fixes:


  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue


  • JDK-8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working



Using git

Checkout this PR locally:
$ git fetch pull/11531/head:pull/11531
$ git checkout pull/11531

Update a local copy of the PR:
$ git checkout pull/11531
$ git pull pull/11531/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11531

View PR using the GUI difftool:
$ git pr show -t 11531

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Dec 6, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link

openjdk bot commented Dec 6, 2022

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Dec 6, 2022
@mrserb mrserb marked this pull request as ready for review December 7, 2022 10:10
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2022
Copy link

mlbridge bot commented Dec 7, 2022


Copy link

openjdk bot commented Dec 8, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2022
Copy link
Member Author

mrserb commented Dec 8, 2022


Copy link

openjdk bot commented Dec 8, 2022

Going to push as commit 5540a8c.
Since your change was applied there have been 107 commits pushed to the master branch:

  • c16eb89: 8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)"
  • 3dfadee: 8292289: [vectorapi] Improve the implementation of VectorTestNode
  • d35e840: 8297295: Remove ThreadGroup.allowThreadSuspension
  • 175e3d3: 8296149: Start of release updates for JDK 21
  • d562d3f: 8297642: PhaseIdealLoop::only_has_infinite_loops must detect all loops that never lead to termination
  • fc52f21: 8298255: JFR provide information about dynamization of number of compiler threads
  • e555d54: 8298383: JFR: lacks copyright header
  • c084431: 8298379: JFR: Some UNTIMED events only sets endTime
  • ea108f5: 8298129: Let checkpoint event sizes grow beyond u4 limit
  • 165dcdd: 8297718: Make NMT free:ing protocol more granular
  • ... and 97 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2022
@openjdk openjdk bot closed this Dec 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2022
Copy link

openjdk bot commented Dec 8, 2022

@mrserb Pushed as commit 5540a8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8298083 branch December 9, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
client integrated Pull request has been integrated
2 participants