8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

[mrserb]

We have two types of properties in Swing, the "basics": were implemented a long time ago. Some of that properties are tested by the bug4314194 test. And other properties implemented as part of the Synth L&F, and based on it - Nimbus/GTK. Attempt to fix the issue reported by bug4314194 added support of two "basic" options to the Nimbus/GTK but at the same time broke the Synth/Nimbus properties. It is unclear what is the root cause and how these properties should work together(should they? I assume each "basic"/"synth" should support its own) I suggest to revert the changes in 20 to prevent the regression and rethink the solution later.

In short, this is a request to revert the next fixes:

• https://bugs.openjdk.org/browse/JDK-8075916 - for some reason broke the Synth/Nimbus properties
• https://bugs.openjdk.org/browse/JDK-8295006 - This uses the same approach as the fix above
  The next two issues created to redo both:
• https://bugs.openjdk.org/browse/JDK-8298149
• https://bugs.openjdk.org/browse/JDK-8298153

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11531/head:pull/11531
$ git checkout pull/11531

Update a local copy of the PR:
$ git checkout pull/11531
$ git pull https://git.openjdk.org/jdk pull/11531/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11531

View PR using the GUI difftool:
$ git pr show -t 11531

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11531.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c36d21c4)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

• 1166c8e: 8296896: Change virtual Thread.yield to use external submit
• 5175965: 8298323: trivial typo in JOptionPane.OK_OPTION
• d5cf18e: 8296198: JFileChooser throws InternalError java.lang.InternalError with Windows shortcuts
• 74f346b: 8298075: RISC-V: Implement post-call NOPs
• 3aa4070: 8294047: HttpResponseInputStream swallows interrupts
• af8fb7e: 8282578: AIOOBE in javax.sound.sampled.Clip
• 8b69a2e: 8298099: [JVMCI] decouple libgraal from JVMCI module at runtime
• 8a9911e: 8295803: Console should be usable in jshell and other environments
• 5d4c71c: 8281236: (D)TLS key exchange named groups
• 10356e7: 8298303: (fs) temporarily remove Path.getExtension
• ... and 77 more: https://git.openjdk.org/jdk/compare/3b3bbe5487c0d86305f953528884b1ee78ca359f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

Going to push as commit 5540a8c.
Since your change was applied there have been 107 commits pushed to the master branch:

• c16eb89: 8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)"
• 3dfadee: 8292289: [vectorapi] Improve the implementation of VectorTestNode
• d35e840: 8297295: Remove ThreadGroup.allowThreadSuspension
• 175e3d3: 8296149: Start of release updates for JDK 21
• d562d3f: 8297642: PhaseIdealLoop::only_has_infinite_loops must detect all loops that never lead to termination
• fc52f21: 8298255: JFR provide information about dynamization of number of compiler threads
• e555d54: 8298383: JFR: GenerateJfrFiles.java lacks copyright header
• c084431: 8298379: JFR: Some UNTIMED events only sets endTime
• ea108f5: 8298129: Let checkpoint event sizes grow beyond u4 limit
• 165dcdd: 8297718: Make NMT free:ing protocol more granular
• ... and 97 more: https://git.openjdk.org/jdk/compare/3b3bbe5487c0d86305f953528884b1ee78ca359f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 5540a8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.