8298175: JFR: Common timestamp for periodic events

[egahlin]

Could I have review of infrastructure that makes it easier to write periodic events with the same timestamp.

Testing: jdk/jdk/jfr + tier1 + tier2

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298175: JFR: Common timestamp for periodic events

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 605f1290
• Markus Grönlund (@mgronlun - Reviewer) ⚠️ Review applies to 605f1290

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11541/head:pull/11541
$ git checkout pull/11541

Update a local copy of the PR:
$ git checkout pull/11541
$ git pull https://git.openjdk.org/jdk pull/11541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11541

View PR using the GUI difftool:
$ git pr show -t 11541

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11541.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following labels will be automatically applied to this pull request:

• build
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (638803b2)
• 01: Full - Incremental (605f1290)
• 00: Full (96146720)

[dholmes-ora]

This seems okay. A couple of comments below.

Thanks.

[dholmes-ora]

Thanks for the update.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298175: JFR: Common timestamp for periodic events

Reviewed-by: dholmes, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 6ed3683: 8297209: Serial: Refactor GenCollectedHeap::full_process_roots
• 86270e3: 8269820: C2 PhaseIdealLoop::do_unroll get wrong opaque node
• cf63f2e: 8298184: Incorrect record component type in record patterns
• 58170f6: 8298035: Provide better descriptions for JIT compiler JFR events
• bfcc238: 8297964: Jetty.java fails "assert(_no_handle_mark_nesting == 0) failed: allocating handle inside NoHandleMark"
• 3e041eb: 8298248: Limit sscanf output width in cgroup file parsers
• 4da8411: 8298108: Add a regression test for JDK-8297684
• 80cbfab: 8298169: Remove unused methods in space.hpp
• 221e1a4: 8286666: JEP 429: Implementation of Scoped Values (Incubator)
• ccc69af: 8296672: Implementation of Virtual Threads (Second Preview)
• ... and 17 more: https://git.openjdk.org/jdk/compare/1e468320dc6e495343dbdf392cbcbda79672c7ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 9353899.
Since your change was applied there have been 52 commits pushed to the master branch:

• 94575d1: 8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead
• 49b8622: 8290850: C2: create_new_if_for_predicate() does not clone pinned phi input nodes resulting in a broken graph
• 2f426cd: 8298375: Bad copyright header in test/jdk/java/lang/Character/Supplementary.java
• b9346e1: 8298033: Character.codePoint{At|Before}(char[], int, int) doesn't do JavaDoc-specified check
• 297bf6a: 8287397: Print top-level exception when snippet fails to read file
• 073897c: 8294588: Auto vectorize half precision floating point conversion APIs
• 46cd457: 8298341: Ensure heap growth in TestNativeMemoryUsageEvents.java
• 1166c8e: 8296896: Change virtual Thread.yield to use external submit
• 5175965: 8298323: trivial typo in JOptionPane.OK_OPTION
• d5cf18e: 8296198: JFileChooser throws InternalError java.lang.InternalError with Windows shortcuts
• ... and 42 more: https://git.openjdk.org/jdk/compare/1e468320dc6e495343dbdf392cbcbda79672c7ad...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 9353899.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.