Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298214: ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java #11548

Closed
wants to merge 4 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 6, 2022

A trivial fix to ProblemList 4 different tests:
JDK-8298214 ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java
JDK-8298218 ProblemList java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java on windows-x64
JDK-8298220 ProblemList java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java on windows-x64
JDK-8298222 ProblemList java/awt/Mixing/AWT_Mixing/ViewportOverlapping.java on windows-x64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8298214: ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java
  • JDK-8298218: ProblemList java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java on windows-x64
  • JDK-8298222: ProblemList java/awt/Mixing/AWT_Mixing/ViewportOverlapping.java on windows-x64
  • JDK-8298220: ProblemList java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java on windows-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11548/head:pull/11548
$ git checkout pull/11548

Update a local copy of the PR:
$ git checkout pull/11548
$ git pull https://git.openjdk.org/jdk pull/11548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11548

View PR using the GUI difftool:
$ git pr show -t 11548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11548.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/issue add JDK-8298214
/issue add JDK-8298218
/issue add JDK-8298220
/issue add JDK-8298222

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs
/label add client

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 6, 2022 21:42
@openjdk openjdk bot changed the title Jdk 8298214 8298214: ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298218: ProblemList java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java on windows-x64.

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298214: ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java
8298218: ProblemList java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java on windows-x64
8298222: ProblemList java/awt/Mixing/AWT_Mixing/ViewportOverlapping.java on windows-x64
8298220: ProblemList java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java on windows-x64

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b4da0ee: 8296507: GCM using more memory than necessary with in-place operations
  • cd2182a: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic
  • 2cdc019: 8298178: Update to use jtreg 7.1.1
  • 79d163d: 8293412: Remove unnecessary java.security.egd overrides

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk The issue 8298220 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298222: ProblemList java/awt/Mixing/AWT_Mixing/ViewportOverlapping.java on windows-x64.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/issue add JDK-8298220

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 6, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298220: ProblemList java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java on windows-x64.

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit 16a5901.
Since your change was applied there have been 4 commits pushed to the master branch:

  • b4da0ee: 8296507: GCM using more memory than necessary with in-place operations
  • cd2182a: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic
  • 2cdc019: 8298178: Update to use jtreg 7.1.1
  • 79d163d: 8293412: Remove unnecessary java.security.egd overrides

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@dcubed-ojdk Pushed as commit 16a5901.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8298214 branch December 8, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants