-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8298225: [AIX] Disable PPC64LE continuations on AIX #11550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298225: [AIX] Disable PPC64LE continuations on AIX #11550
Conversation
|
👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into |
|
@backwaterred The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout build/aix/continuation-enabled
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainline will get forked today. Please create a new PR in the JDK 20 stabilization
repository once it's available. This one get get closed afterwards.
| AD.addInclude(AD._CPP_file, "opto/regalloc.hpp"); | ||
| AD.addInclude(AD._CPP_file, "opto/regmask.hpp"); | ||
| AD.addInclude(AD._CPP_file, "opto/runtime.hpp"); | ||
| AD.addInclude(AD._CPP_file, "runtime/continuation.hpp"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds it for all platforms. Isn't it sufficient to add it in source %{ section of the ad file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that first, but may have done so incorrectly. I am trying again.
|
https://github.com/openjdk/jdk20 is now open for P3 bug fixes. (They will get merged into this repo after some time.) |
Thanks. I am closing this PR, and will re-open one on jdk20 after learning if the ppc.ad modification is feasible. The build is looking good so far, so I suspect it was my error that kept it from working the first time. |
This small change adds an import to the generated ad_ppc.cpp file to allow it to find Contiuations::enabled, and sets VMContinuations to false on AIX.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11550/head:pull/11550$ git checkout pull/11550Update a local copy of the PR:
$ git checkout pull/11550$ git pull https://git.openjdk.org/jdk pull/11550/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11550View PR using the GUI difftool:
$ git pr show -t 11550Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11550.diff