8244400: MenuItem may cache the size and did not update it when the screen DPI is changed

[prsadhuk]

The MenuItemLayoutHelper.clearUsedParentClientProperties must be called automatically when the DPI was changed.
Workaround added in the test for this bug is removed.

CI tests are ok.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8244400: MenuItem may cache the size and did not update it when the screen DPI is changed

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11551/head:pull/11551
$ git checkout pull/11551

Update a local copy of the PR:
$ git checkout pull/11551
$ git pull https://git.openjdk.org/jdk pull/11551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11551

View PR using the GUI difftool:
$ git pr show -t 11551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11551.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (f4d23947)
• 01: Full - Incremental (51feefa5)
• 00: Full (98ec1e5d)

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8244400: MenuItem may cache the size and did not update it when the screen DPI is changed

Reviewed-by: serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 138 new commits pushed to the master branch:

• 56c438b: 8297822: De-duplicate code in module jdk.sctp
• fabda24: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
• 6c23b4f: 8298480: Remove unused KlassRemSet
• 8e5c331: 8298471: Parallel: Don't keep alive nmethods in Young GC
• d646e32: 8298090: Use String.join() instead of manual loop in DescriptorSupport.toString
• a37de62: 8298126: Print statistics for objects in CDS archive heap
• 8ea2a67: 8292265: Add old gen used field at G1HeapSummary JFR event
• 478ef38: 8296812: sprintf is deprecated in Xcode 14
• 715bf70: Merge
• a894649: 8298225: [AIX] Disable PPC64LE continuations on AIX
• ... and 128 more: https://git.openjdk.org/jdk/compare/b49fd920b6690a8b828c85e45c10e5c4c54d2022...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bridgekeeper]

@prsadhuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jayathirthrao]

@prsadhuk Are we waiting on something to push this change?

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 11aadc9.
Since your change was applied there have been 651 commits pushed to the master branch:

• 836198a: 8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc
• 45e4e00: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
• 030b071: 8300207: Add a pre-check for the number of canonical equivalent permutations in j.u.r.Pattern
• 7ced08d: 8300638: Tier1 IR Test failure after JDK-8298632 on macosx-x64-debug
• 3ea4eac: 8300817: The build is broken after JDK-8294693
• cbfc069: 8300731: Avoid unnecessary array fill after creation in PaletteBuilder
• 67b1c89: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface
• c8dd758: 8300260: Remove metaprogramming/isSame.hpp
• a6c2a2a: 8300692: GCC 12 reports some compiler warnings in bundled freetype
• bb42e61: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder
• ... and 641 more: https://git.openjdk.org/jdk/compare/b49fd920b6690a8b828c85e45c10e5c4c54d2022...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 11aadc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.