8218474: JComboBox display issue with GTKLookAndFeel #11555

kumarabhi006 · 2022-12-07T10:25:31Z

In case of GTK LAF, the current selected element was not visible due to arrowbutton is rendered in entire display area of Combobox.

The proposed fix is to set the squareButton property of combobox to false so that the arrowbutton didn't take entire combobox display area for rendering. The getMinimumSize method is overridden in SynthComboBoxUI to consider arrowbutton insets for combobox minimum size.

The JCK tests mentioned in JBS seems fine with the fix.
An automated test case is implemented to test in Nimbus and GTK LAF. The text color check is to ensure the current selected item is visible.

When clientlibs tests are run with LAF set to Nimbus and GTK LAF, few test failures observed.

javax/swing/JComboBox/4523758/bug4523758.java test failed with current fix in GTK LAF.
open/test/jdk/javax/swing/JComboBox/TestComboBoxHeight.java test passes if run in GTK LAF with current fix.

In Nimbus LAF, the failures before and after fix has no issues as such.

Although CI jobs looks ok with tests run in their default set LAFs.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8218474: JComboBox display issue with GTKLookAndFeel

Reviewers

Tejesh R (@TejeshR13 - Committer) ⚠️ Review applies to b0db194b
Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11555/head:pull/11555
$ git checkout pull/11555

Update a local copy of the PR:
$ git checkout pull/11555
$ git pull https://git.openjdk.org/jdk pull/11555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11555

View PR using the GUI difftool:
$ git pr show -t 11555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11555.diff

bridgekeeper · 2022-12-07T10:27:38Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-12-07T10:31:54Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-12-07T10:36:13Z

Webrevs

01: Full - Incremental (ea53f8ae)
00: Full (b0db194b)

mrserb · 2022-12-07T10:59:08Z

Looks like the JBS issue is closed:
⚠️ Failed to retrieve information on issue 8218474.

kumarabhi006 · 2022-12-07T11:01:37Z

Looks like the JBS issue is closed: ⚠️ Failed to retrieve information on issue 8218474.

https://bugs.openjdk.org/browse/JDK-8218474

It seems it is not closed.

mrserb · 2022-12-07T22:00:00Z

No it is confidential or something like that. Cannot open/view it.

TejeshR13

TestComboBoxComponentRendering.java test failed (Synth L&F) in Ubuntu_21 VM machine. .jtr file and Failure case screen captured shared.

kumarabhi006 · 2022-12-12T09:37:02Z

No it is confidential or something like that. Cannot open/view it.

@mrserb The bug is open now. Please have a look.

kumarabhi006 · 2022-12-12T10:28:50Z

TestComboBoxComponentRendering.java test failed (Synth L&F) in Ubuntu_21 VM machine. .jtr file and Failure case screen captured shared.

Run the test in Ubuntu 20,21 and 22 in CI pipeline, test passed for all platform.

kumarabhi006 · 2022-12-14T05:01:07Z

@mrserb Please have a look.

TejeshR13 · 2022-12-14T10:18:54Z

TestComboBoxComponentRendering.java test failed (Synth L&F) in Ubuntu_21 VM machine. .jtr file and Failure case screen captured shared.

Run the test in Ubuntu 20,21 and 22 in CI pipeline, test passed for all platform.

The issue was that I was running in wayland, not xorg. The fix is tested and works fine

turbanoff · 2022-12-21T11:27:30Z

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java

+        //adjust the size based on the button width
+        size.height += insets.top + insets.bottom + arrowInsets.top
+                        + arrowInsets.bottom;
+        size.width +=  insets.left + insets.right +arrowInsets.left


Suggested change

size.width += insets.left + insets.right +arrowInsets.left

size.width += insets.left + insets.right + arrowInsets.left

mrserb · 2023-01-03T01:21:07Z

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java

+                            buttonHeight :
+                            arrowButton.getPreferredSize().width;
+        //adjust the size based on the button width
+        size.height += insets.top + insets.bottom + arrowInsets.top


Are you sure that the arrow insets should be applied on top of the component's insets, probably the maximum of both should be selected?

For combobox text to render correctly arrow inset need to be applied otherwise the combobox editor shows "..." even for a smaller text.

Since component inset's return (0, 0, 0, 0) in GTK and Nimbus LAF, didn't take the maximum of both into consideration.

@mrserb Are you ok with the fix or do you want anything to add?

openjdk · 2023-01-09T02:08:28Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8218474: JComboBox display issue with GTKLookAndFeel

Reviewed-by: tr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 113 new commits pushed to the master branch:

7607c07: 8299774: SYNTH_BUTTON_UI_KEY field is unused
d53cac3: 8299481: Remove metaprogramming/removePointer.hpp
834e50e: 8298921: Create a regression test for JDK-8139581
e209693: 8258776: ThreadLocal#initialValue() Javadoc is unaware of ThreadLocal#withInitial()
d5b80ab: 8299617: CurrencySymbols.properties is missing the copyright notice
63cf4aa: 8299499: Usage of constructors of primitive wrapper classes should be avoided in java.net API docs
5393dc9: Merge
1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
... and 103 more: https://git.openjdk.org/jdk/compare/50120396b6cca1219fb5dd42a11e4b29b79bd3bd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TejeshR13, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

kumarabhi006 · 2023-01-09T03:04:36Z

/integrate

openjdk · 2023-01-09T03:09:58Z

@kumarabhi006
Your change (at version ea53f8a) is now ready to be sponsored by a Committer.

TejeshR13 · 2023-01-09T04:36:36Z

/sponsor

openjdk · 2023-01-09T04:47:43Z

Going to push as commit c444922.
Since your change was applied there have been 113 commits pushed to the master branch:

7607c07: 8299774: SYNTH_BUTTON_UI_KEY field is unused
d53cac3: 8299481: Remove metaprogramming/removePointer.hpp
834e50e: 8298921: Create a regression test for JDK-8139581
e209693: 8258776: ThreadLocal#initialValue() Javadoc is unaware of ThreadLocal#withInitial()
d5b80ab: 8299617: CurrencySymbols.properties is missing the copyright notice
63cf4aa: 8299499: Usage of constructors of primitive wrapper classes should be avoided in java.net API docs
5393dc9: Merge
1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
... and 103 more: https://git.openjdk.org/jdk/compare/50120396b6cca1219fb5dd42a11e4b29b79bd3bd...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-09T04:49:38Z

@TejeshR13 @kumarabhi006 Pushed as commit c444922.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Combobox componnet rendering fix

b0db194

openjdk bot added the rfr Pull request is ready for review label Dec 7, 2022

openjdk bot added the client client-libs-dev@openjdk.org label Dec 7, 2022

Merge

ed817a4

TejeshR13 reviewed Dec 12, 2022

View reviewed changes

TejeshR13 approved these changes Dec 14, 2022

View reviewed changes

turbanoff reviewed Dec 21, 2022

View reviewed changes

kumarabhi006 added 2 commits December 22, 2022 14:36

Merge

62ec10d

Review comment update

ea53f8a

mrserb reviewed Jan 3, 2023

View reviewed changes

mrserb approved these changes Jan 9, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2023

openjdk bot added the integrated Pull request has been integrated label Jan 9, 2023

openjdk bot closed this Jan 9, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2023

	size.width += insets.left + insets.right +arrowInsets.left
	size.width += insets.left + insets.right + arrowInsets.left

8218474: JComboBox display issue with GTKLookAndFeel #11555

8218474: JComboBox display issue with GTKLookAndFeel #11555

Uh oh!

Conversation

kumarabhi006 commented Dec 7, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Dec 7, 2022

Uh oh!

openjdk bot commented Dec 7, 2022

Uh oh!

mlbridge bot commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

mrserb commented Dec 7, 2022

Uh oh!

kumarabhi006 commented Dec 7, 2022

Uh oh!

mrserb commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kumarabhi006 commented Dec 12, 2022

Uh oh!

kumarabhi006 commented Dec 14, 2022

Uh oh!

TejeshR13 commented Dec 14, 2022

Uh oh!

turbanoff Dec 21, 2022

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Dec 22, 2022

Choose a reason for hiding this comment

Uh oh!

mrserb Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jan 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kumarabhi006 commented Jan 9, 2023

Uh oh!

openjdk bot commented Jan 9, 2023

Uh oh!

TejeshR13 commented Jan 9, 2023

Uh oh!

openjdk bot commented Jan 9, 2023

Uh oh!

openjdk bot commented Jan 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

kumarabhi006 commented Dec 7, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 7, 2022 •

edited

Loading

mrserb commented Dec 7, 2022 •

edited

Loading

kumarabhi006 commented Dec 12, 2022 •

edited

Loading

kumarabhi006 Jan 3, 2023 •

edited

Loading

openjdk bot commented Jan 9, 2023 •

edited

Loading