Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298272: Clean up ProblemList #11561

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Dec 7, 2022

Removed two entries from the problem list that refer to issues that were fixed/closed. Tests are running.

Thanks,
Tobias


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11561/head:pull/11561
$ git checkout pull/11561

Update a local copy of the PR:
$ git checkout pull/11561
$ git pull https://git.openjdk.org/jdk pull/11561/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11561

View PR using the GUI difftool:
$ git pr show -t 11561

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11561.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@TobiHartmann To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@TobiHartmann
Copy link
Member Author

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@TobiHartmann
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 7, 2022

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial!

@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298272: Clean up ProblemList

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 3934484: 8298205: Prefer Member Initialization Lists for JFR classes in os_perf.hpp
  • 389b8f4: 8297298: SequenceInputStream should override transferTo
  • dd7385d: 8298202: [AIX] Dead code elimination removed jfr constructor used by AIX
  • 29f1c3c: 8298274: Problem list TestSPISigned on Windows
  • 3de7750: 8298177: Various java.lang.invoke cleanups
  • 6ed3683: 8297209: Serial: Refactor GenCollectedHeap::full_process_roots

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2022
@TobiHartmann
Copy link
Member Author

Thanks for the reviews, Vladimir and Christian.

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2022

Going to push as commit d8ef60b.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 9353899: 8298175: JFR: Common timestamp for periodic events
  • 94575d1: 8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead
  • 49b8622: 8290850: C2: create_new_if_for_predicate() does not clone pinned phi input nodes resulting in a broken graph
  • 2f426cd: 8298375: Bad copyright header in test/jdk/java/lang/Character/Supplementary.java
  • b9346e1: 8298033: Character.codePoint{At|Before}(char[], int, int) doesn't do JavaDoc-specified check
  • 297bf6a: 8287397: Print top-level exception when snippet fails to read file
  • 073897c: 8294588: Auto vectorize half precision floating point conversion APIs
  • 46cd457: 8298341: Ensure heap growth in TestNativeMemoryUsageEvents.java
  • 1166c8e: 8296896: Change virtual Thread.yield to use external submit
  • 5175965: 8298323: trivial typo in JOptionPane.OK_OPTION
  • ... and 17 more: https://git.openjdk.org/jdk/compare/86270e3068d3b2e80710227ae2dc79719df35788...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2022
@openjdk openjdk bot closed this Dec 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2022
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@TobiHartmann Pushed as commit d8ef60b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants